Skip to content

Support Composite types #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hoverbear wants to merge 2 commits into from
Closed

Support Composite types #57

Hoverbear wants to merge 2 commits into from

Conversation

@Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Jul 4, 2022

This is based off #51 which is based off #56 so it's a long way from being ready to merge.

CREATE TYPE Dog AS (
    name TEXT,
    scritches INT
);

CREATE FUNCTION last_dog(a Dog[]) RETURNS Dog
    IMMUTABLE STRICT
    LANGUAGE PLRUST AS
$$
    a.into_iter().last().unwrap_or(None)
$$;

@Hoverbear Hoverbear self-assigned this Jul 4, 2022
@Hoverbear Hoverbear mentioned this pull request Jul 4, 2022
Merged
eeeebbbbrrrr
eeeebbbbrrrr reviewed Jul 5, 2022
View reviewed changes
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib.rs
Some(String::from_utf8(output.stdout.clone()).expect("`cargo`'s stdout was not UTF-8")),
Some(String::from_utf8(output.stderr.clone()).expect("`cargo`'s stderr was not UTF-8")),
Some(
String::from_utf8(output.stdout.clone()).expect("`cargo`'s stdout was not UTF-8"),
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr Jul 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space before UTF-8

src/lib.rs
String::from_utf8(output.stdout.clone()).expect("`cargo`'s stdout was not UTF-8"),
),
Some(
String::from_utf8(output.stderr.clone()).expect("`cargo`'s stderr was not UTF-8"),
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr Jul 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@eeeebbbbrrrr
Copy link
Contributor

eeeebbbbrrrr commented Jul 5, 2022

Should probably look into the CI failures, eh?

@Hoverbear Hoverbear mentioned this pull request Jul 20, 2022
Merged
@johnrballard johnrballard mentioned this pull request Aug 18, 2022
Open
@Hoverbear @workingjubilee
Add composite_type!() support
cff7a30 
Signed-off-by: Ana Hobden <operator@hoverbear.org>
@workingjubilee workingjubilee mentioned this pull request Oct 21, 2022
Open
workingjubilee
workingjubilee reviewed Oct 21, 2022
View reviewed changes
src/tests.rs
Comment on lines +67 to +72
let composite_type_oid: u32 = unsafe {
let mut typoid = 0;
let mut typmod = 0;
pg_sys::parseTypeString("Dog".as_pg_cstr(), &mut typoid, &mut typmod, false);
typoid
};
Copy link
Contributor

@workingjubilee workingjubilee Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to find a way to wrap this outside this function before this is acceptable.

eeeebbbbrrrr added a commit that referenced this pull request May 24, 2023
@eeeebbbbrrrr
working on composite type support. this will replace PR #57 when comp…
6875cc1 
…lete.
eeeebbbbrrrr added a commit that referenced this pull request May 31, 2023
@eeeebbbbrrrr
working on composite type support. this will replace PR #57 when comp…
26a78b7 
…lete.
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request May 31, 2023
Merged
@eeeebbbbrrrr
Copy link
Contributor

eeeebbbbrrrr commented Jun 1, 2023

replaced by PR #311. Not really much actual code difference here -- was just easier to write the few lines of code again rather than deal with the merge conflicts since we've moved files around since this PR was created. #311 also included docs and updated to plrust-trusted-pgrx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@eeeebbbbrrrr eeeebbbbrrrr eeeebbbbrrrr left review comments

@workingjubilee workingjubilee workingjubilee left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Hoverbear Hoverbear

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hoverbear @eeeebbbbrrrr @workingjubilee