Add triggers #51

Hoverbear · 2022-05-27T21:42:21Z

Based off #56 , is a draft until it merges.

Requires the experimental develop-v0.5.0 PGX branch locally! Test with:

PLRUST_EXPERIMENTAL_CRATES=/home/ana/git/zombodb/pgx/pgx cargo pgx run

Then:

DROP EXTENSION IF EXISTS plrust CASCADE; CREATE EXTENSION plrust;

CREATE TABLE dogs (
    name TEXT,
    scritches INT NOT NULL DEFAULT 0
);
 
CREATE FUNCTION pet_trigger() RETURNS trigger AS $$
    let current = trigger.current().unwrap();
    let mut current = current.into_owned();

    let field = "scritches";

    match current.get_by_name::<i32>(field).unwrap() {
        Some(val) => current.set_by_name(field, val + 1).unwrap(),
        None => (),
    }

    Ok(current)
$$ LANGUAGE plrust;

CREATE TRIGGER pet_trigger BEFORE INSERT OR UPDATE ON dogs
    FOR EACH ROW EXECUTE FUNCTION pet_trigger();

INSERT INTO dogs (name) VALUES ('Nami');

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Hoverbear · 2022-07-04T16:43:31Z

This is based off #56 :)

workingjubilee

I think this looks good! My commentary is mostly so extensive like this, including some remarks that aren't actually about your code, because I realized that everything that bothered or confused me about the code here is something that

this PR is not directly responsible for
I can also probably fix this week
expressing inclinations may elicit concurrence, disagreement, or other discussion for future direction, so I should do it now.

So I figured I should immediately leave as many notes as possible even if they make this less of a review and more of a running stream. Thus if you have any inclination for commentary on my commentary you are welcome to it, but this is good to merge this as-is and we can address improvements in followups.

src/tests.rs

src/user_crate/state_generated.rs

workingjubilee · 2022-07-05T19:36:05Z

src/user_crate/state_generated.rs

+                    fn #symbol_ident(
+                        trigger: &::pgx::PgTrigger,
+                    ) -> core::result::Result<
+                        ::pgx::heap_tuple::PgHeapTuple<'_, impl ::pgx::WhoAllocated<::pgx::pg_sys::HeapTupleData>>,


I need to get back to refactoring the allocation code in PGX, now that it's creeping more into this codebase again.

src/user_crate/state_generated.rs

src/tests.rs

src/user_crate/state_generated.rs

workingjubilee · 2022-07-05T20:38:00Z

src/user_crate/crate_variant.rs

+    #[tracing::instrument(level = "debug", skip_all)]
+    pub(crate) fn trigger() -> Self {
+        Self::Trigger
+    }


I'm guessing this constructor is mostly for tracing purposes?

I think also to avoid future me going "Why is there no ctor for this?" as I am known to do.

Hoverbear added 30 commits May 13, 2022 12:58

Improve error handling

c1a8ed6

Signed-off-by: Ana Hobden <operator@hoverbear.org>

More error handling

f90a693

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Fancy errors

d050b76

Signed-off-by: Ana Hobden <operator@hoverbear.org>

fmt

7f4ad88

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Add missing #[from]

9f45e65

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Fix mac code

4f9068b

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Use pub(crate) for generations

d1bc8f3

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Pub crate error

3d99c64

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Pub gen error

6d843ef

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Use syn/quote and toml parsing

91224b7

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Fixup small issues

172b988

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Tweak logging levels

feebd5c

Signed-off-by: Ana Hobden <operator@hoverbear.org>

More isntrument changes

eb740b9

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Refine levels

dd2c733

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Tidy

ae2e040

Signed-off-by: Ana Hobden <operator@hoverbear.org>

tidy an error

628a634

Signed-off-by: Ana Hobden <operator@hoverbear.org>

fmt

555a35d

Signed-off-by: Ana Hobden <operator@hoverbear.org>

fixup how we detect log levels

d531cd2

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Fixup setof support

0012fe6

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Support non-strict

cdb60d8

Signed-off-by: Ana Hobden <operator@hoverbear.org>

fmt

1894bd6

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Merge branch 'error-handling' into syn-and-quote

0967788

Clean up some errors

209b48a

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Extract tests

235eb04

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Add agg test

abf5553

Signed-off-by: Ana Hobden <operator@hoverbear.org>

fmt

2519b1d

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Merge branch 'main' into syn-and-quote

7fa40d7

Restore ownership information

a062926

Signed-off-by: Ana Hobden <operator@hoverbear.org>

fmt

8f40a38

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Merge branch 'main' into syn-and-quote

6fb7093

Jubilee Young and others added 19 commits June 29, 2022 16:17

nada

1a9c36b

Skip ahead to postgrestd tests

66b42d2

void*

64a355a

Drag nightly version ahead a few

f9db737

Try a cargo clean

5d216b9

Run full test suite without clean

ccae8da

Build a matrix again

5aa302c

One clean for good fun

d1bcb24

Attempt to fix Mac again

954d269

Patch pgx-tests to develop also

896c04c

I really hope this does not work

f325b3e

Poke everything once

0a6d3d6

Merge branch 'using-postgrestd' into add-triggers

18a960d

Remove no_std annotations

6196538

Install cargo pgx from git

09aaf8e

Force install with the right URL

8506869

Move forward with Ubuntu 22 in CI

0a88f8f

Oops I meant Ubuntu 20

79c22a2

Fix lints

b1bad51

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Merge branch 'using-postgrestd' into add-triggers

97c127f

Hoverbear force-pushed the add-triggers branch from cb0ede0 to 97c127f Compare July 4, 2022 16:47

This was referenced Jul 4, 2022

Support Composite types #57

Closed

Enable using postgrestd #56

Merged

Merge branch 'main' into add-triggers

5d1babb

Hoverbear marked this pull request as ready for review July 5, 2022 18:12

Fix minor formatting details in fixture test

74d0792

workingjubilee approved these changes Jul 5, 2022

View reviewed changes

workingjubilee merged commit 0e88013 into main Jul 5, 2022

johnrballard mentioned this pull request Aug 18, 2022

RFC: Trigger Support pgcentralfoundation/pgrx#503

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add triggers #51

Add triggers #51

Uh oh!

Hoverbear commented May 27, 2022 •

edited

Loading

Uh oh!

Hoverbear commented Jul 4, 2022

Uh oh!

workingjubilee left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

workingjubilee Jul 5, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

workingjubilee Jul 5, 2022

Uh oh!

Hoverbear Jul 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add triggers #51

Add triggers #51

Uh oh!

Conversation

Hoverbear commented May 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hoverbear commented Jul 4, 2022

Uh oh!

workingjubilee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

workingjubilee Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

workingjubilee Jul 5, 2022

Choose a reason for hiding this comment

Uh oh!

Hoverbear Jul 5, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Hoverbear commented May 27, 2022 •

edited

Loading

workingjubilee Jul 5, 2022 •

edited

Loading