Normative: Reject too large dates in ToTemporalMonthDay#3054
Merged
Normative: Reject too large dates in ToTemporalMonthDay#3054
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3054 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 21 21
Lines 9928 9929 +1
Branches 1801 1801
=======================================
+ Hits 9545 9546 +1
Misses 336 336
Partials 47 47 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Thanks. We'll discuss this in the next champions meeting. |
ptomato
requested changes
Jan 14, 2025
Collaborator
ptomato
left a comment
There was a problem hiding this comment.
Could we make the diff to be presented as minimal as possible? Ideally just the two edits in plainmonthday.html. Since the PlainYearMonth change is unobservable, I'd be happy to accept a PR for it beforehand.
ptomato
pushed a commit
that referenced
this pull request
Feb 5, 2025
…earMonth The call to `CalendarYearMonthFromFields` will already reject too large dates, but adding an explicit step makes it more obvious that `ISODateToFields` doesn't require support for mapping large ISO dates to calendar dates. And it also aligns `ToTemporalYearMonth` with `ToTemporalMonthDay` after #3054.
Ms2ger
pushed a commit
that referenced
this pull request
Feb 5, 2025
…earMonth The call to `CalendarYearMonthFromFields` will already reject too large dates, but adding an explicit step makes it more obvious that `ISODateToFields` doesn't require support for mapping large ISO dates to calendar dates. And it also aligns `ToTemporalYearMonth` with `ToTemporalMonthDay` after #3054.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Feb 5, 2025
…y strings This adds coverage for the normative change in tc39/proposal-temporal#3054, which specifies that implementations must throw on out-of-range dates in RFC 9557 strings for non-ISO calendars.
Collaborator
|
Tests are in tc39/test262#4389. |
3ce9a20 to
19f17f6
Compare
ptomato
approved these changes
Feb 5, 2025
Collaborator
|
Draft until approved in TC39. |
Collaborator
|
Approved in the TC39 plenary of 2025-02-18. I'll pull in the test262 update before merging this. |
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Feb 22, 2025
…y strings This adds coverage for the normative change in tc39/proposal-temporal#3054, which specifies that implementations must throw on out-of-range dates in RFC 9557 strings for non-ISO calendars.
ptomato
added a commit
to tc39/test262
that referenced
this pull request
Feb 22, 2025
…y strings This adds coverage for the normative change in tc39/proposal-temporal#3054, which specifies that implementations must throw on out-of-range dates in RFC 9557 strings for non-ISO calendars.
19f17f6 to
a143609
Compare
Implements the normative change from the previous commit in the reference code.
a143609 to
1cfbd3d
Compare
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 1, 2025
…=spidermonkey-reviewers,mgaudet Implement the changes from <tc39/proposal-temporal#3054>. Differential Revision: https://phabricator.services.mozilla.com/D243635
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Apr 3, 2025
…=spidermonkey-reviewers,mgaudet Implement the changes from <tc39/proposal-temporal#3054>. Differential Revision: https://phabricator.services.mozilla.com/D243635 UltraBlame original commit: b21a4423ba2dc0a2a468bbbbced4decaa03a6c9b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Apr 3, 2025
…=spidermonkey-reviewers,mgaudet Implement the changes from <tc39/proposal-temporal#3054>. Differential Revision: https://phabricator.services.mozilla.com/D243635 UltraBlame original commit: b21a4423ba2dc0a2a468bbbbced4decaa03a6c9b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Apr 3, 2025
…=spidermonkey-reviewers,mgaudet Implement the changes from <tc39/proposal-temporal#3054>. Differential Revision: https://phabricator.services.mozilla.com/D243635 UltraBlame original commit: b21a4423ba2dc0a2a468bbbbced4decaa03a6c9b
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Apr 4, 2025
…=spidermonkey-reviewers,mgaudet Implement the changes from <tc39/proposal-temporal#3054>. Differential Revision: https://phabricator.services.mozilla.com/D243635
globau
pushed a commit
to globau/firefox-test
that referenced
this pull request
Apr 8, 2025
…=spidermonkey-reviewers,mgaudet Implement the changes from <tc39/proposal-temporal#3054>. Differential Revision: https://phabricator.services.mozilla.com/D243635
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3008 / #3002 to reject too large dates.