Skip to content

Editorial: Clarify requirement for implementation-defined month-day validation#3008

Merged
ptomato merged 1 commit intomainfrom
3002-month-day-range-error
Oct 9, 2024
Merged

Editorial: Clarify requirement for implementation-defined month-day validation#3008
ptomato merged 1 commit intomainfrom
3002-month-day-range-error

Conversation

@ptomato
Copy link
Collaborator

@ptomato ptomato commented Oct 8, 2024

This is a speculative PR for what I think is probably the best way to address #3002.

Closes: #3002

@codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (e6660f2) to head (ad1ff26).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3008   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files          21       21           
  Lines        9678     9678           
  Branches     1837     1837           
=======================================
  Hits         9281     9281           
  Misses        344      344           
  Partials       53       53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justingrant
justingrant approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@justingrant justingrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@ptomato
Copy link
Collaborator Author

ptomato commented Oct 9, 2024

Let's go ahead with this so that Anba can be unblocked and we have a clean slate for the plenary presentation.

@ptomato ptomato merged commit c75c841 into main Oct 9, 2024
@ptomato ptomato deleted the 3002-month-day-range-error branch October 9, 2024 01:03
anba added a commit to anba/proposal-temporal that referenced this pull request Dec 9, 2024
@anba
Normative: Disallow large dates in ToTemporalMonthDay
c5ad4b0 
Follow-up to tc39#3008 (tc39#3002). Similar to CalendarMonthDayToISOReferenceDate, also
don't require support for mapping ISO dates up to ±999999-12-31 to
calendar dates. This restriction does not apply to the ISO 8601
calendar.
@anba anba mentioned this pull request Dec 9, 2024
Merged
ptomato pushed a commit to anba/proposal-temporal that referenced this pull request Feb 5, 2025
@anba @ptomato
Normative: Disallow large dates in ToTemporalMonthDay
aad7bdc 
Follow-up to tc39#3008 (tc39#3002). Similar to CalendarMonthDayToISOReferenceDate, also
don't require support for mapping ISO dates up to ±999999-12-31 to
calendar dates. This restriction does not apply to the ISO 8601
calendar.
ptomato pushed a commit to anba/proposal-temporal that referenced this pull request Feb 22, 2025
@anba @ptomato
Normative: Disallow large dates in ToTemporalMonthDay
5558d73 
Follow-up to tc39#3008 (tc39#3002). Similar to CalendarMonthDayToISOReferenceDate, also
don't require support for mapping ISO dates up to ±999999-12-31 to
calendar dates. This restriction does not apply to the ISO 8601
calendar.
ptomato pushed a commit to anba/proposal-temporal that referenced this pull request Feb 22, 2025
@anba @ptomato
Normative: Disallow large dates in ToTemporalMonthDay
20892bc 
Follow-up to tc39#3008 (tc39#3002). Similar to CalendarMonthDayToISOReferenceDate, also
don't require support for mapping ISO dates up to ±999999-12-31 to
calendar dates. This restriction does not apply to the ISO 8601
calendar.
ptomato pushed a commit that referenced this pull request Feb 22, 2025
@anba @ptomato
Normative: Disallow large dates in ToTemporalMonthDay
bd5ac12 
Follow-up to #3008 (#3002). Similar to CalendarMonthDayToISOReferenceDate, also
don't require support for mapping ISO dates up to ±999999-12-31 to
calendar dates. This restriction does not apply to the ISO 8601
calendar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justingrant justingrant justingrant approved these changes

@gibson042 gibson042 Awaiting requested review from gibson042

@Ms2ger Ms2ger Awaiting requested review from Ms2ger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CalendarMonthDayToISOReferenceDate: Allow to throw RangeError for too large inputs?

2 participants

@ptomato @justingrant