Skip to content

Misc Editorial#1509

Merged
ljharb merged 4 commits intotc39:masterfrom
jmdyck:editorial
May 2, 2019
Merged

Misc Editorial#1509
ljharb merged 4 commits intotc39:masterfrom
jmdyck:editorial

Conversation

@jmdyck
Copy link
Copy Markdown
Collaborator

@jmdyck jmdyck commented Apr 13, 2019

14 commits re a bunch of merges 3 days ago.

@ljharb ljharb requested review from a team, ljharb and zenparsing April 13, 2019 14:54
@ljharb

This comment has been minimized.

@jmdyck

This comment has been minimized.

@ljharb

This comment has been minimized.

@jmdyck

This comment has been minimized.

@jmdyck
Copy link
Copy Markdown
Collaborator Author

jmdyck commented Apr 13, 2019

Done: squashed 11 commits into one. (This PR now has just 4 commits.)

@jmdyck jmdyck force-pushed the editorial branch 2 times, most recently from 5e117fa to 506c22d Compare April 26, 2019 01:06
@ljharb ljharb self-assigned this May 2, 2019
jmdyck added 4 commits May 2, 2019 10:47
These edits all relate to commit 71927e1 from PR tc39#1480.

- Markup: repair a malformed <emu-xref> tag

- Editorial: Append "then" to "If" steps

- Markup: change hyphens to dots in clause-id for String.prototype.matchAll

- Editorial: Change RIGHT SINGLE QUOTATION MARK to APOSTROPHE
  (U+2019 to U+0027)

- Markup: Remove underscores from "_CreateRegExpStringIterator_"
  ... because it's not a variable.

- Editorial: dissolve 2 <emu-xref> elements
  ... that should be handled by ecmarkup's auto-linking.

- Markup: Use conventional format for clause-ids
  (for clauses relating to RegExp String Iterator Object + Instances)

- Editorial: Define %RegExpStringIteratorPrototype% like other intrinsics

- Editorial: Insert space before square-bracket
  ... in "%RegExpStringIteratorPrototype% [ @@toStringTag ]"

- Editorial: Hoist "Properties of RegExp String Iterator Instances" clause
  Move it 'up' one level
  (pop it out of "The %RegExpStringIteratorPrototype% Object" clause),
  because it's not defining a property of %RegExpStringIteratorPrototype%.

- Markup: Tweak "Internal Slots of RegExp String Iterator Instances" table.
  Change <figure>/<figurecaption>/<span> to <emu-table>.
  Change the id from "table-1" to something more mnemonic.
  Delete spurious "<tr>" tag.
  Refer to it with an <emu-xref> rather than an <a> element.

(Originally, these were 11 separate commits,
but @ljharb requested that I collapse them.)
@ljharb ljharb merged commit 5c93a68 into tc39:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants