Normative: add String.prototype.matchAll/Symbol.matchAll#1480
Merged
ljharb merged 1 commit intotc39:masterfrom Apr 10, 2019
Merged
Normative: add String.prototype.matchAll/Symbol.matchAll#1480ljharb merged 1 commit intotc39:masterfrom
String.prototype.matchAll/Symbol.matchAll#1480ljharb merged 1 commit intotc39:masterfrom
Conversation
28 tasks
mathiasbynens
approved these changes
Mar 15, 2019
Member
littledan
approved these changes
Mar 19, 2019
zenparsing
approved these changes
Mar 26, 2019
Merged
5 tasks
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Apr 29, 2019
These edits all relate to commit 71927e1 from PR tc39#1480. - Markup: repair a malformed <emu-xref> tag - Editorial: Append "then" to "If" steps - Markup: change hyphens to dots in clause-id for String.prototype.matchAll - Editorial: Change RIGHT SINGLE QUOTATION MARK to APOSTROPHE (U+2019 to U+0027) - Markup: Remove underscores from "_CreateRegExpStringIterator_" ... because it's not a variable. - Editorial: dissolve 2 <emu-xref> elements ... that should be handled by ecmarkup's auto-linking. - Markup: Use conventional format for clause-ids (for clauses relating to RegExp String Iterator Object + Instances) - Editorial: Define %RegExpStringIteratorPrototype% like other intrinsics - Editorial: Insert space before square-bracket ... in "%RegExpStringIteratorPrototype% [ @@toStringTag ]" - Editorial: Hoist "Properties of RegExp String Iterator Instances" clause Move it 'up' one level (pop it out of "The %RegExpStringIteratorPrototype% Object" clause), because it's not defining a property of %RegExpStringIteratorPrototype%. - Markup: Tweak "Internal Slots of RegExp String Iterator Instances" table. Change <figure>/<figurecaption>/<span> to <emu-table>. Change the id from "table-1" to something more mnemonic. Delete spurious "<tr>" tag. Refer to it with an <emu-xref> rather than an <a> element. (Originally, these were 11 separate commits, but @ljharb requested that I collapse them.)
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
May 2, 2019
These edits all relate to commit 71927e1 from PR tc39#1480. - Markup: repair a malformed <emu-xref> tag - Editorial: Append "then" to "If" steps - Markup: change hyphens to dots in clause-id for String.prototype.matchAll - Editorial: Change RIGHT SINGLE QUOTATION MARK to APOSTROPHE (U+2019 to U+0027) - Markup: Remove underscores from "_CreateRegExpStringIterator_" ... because it's not a variable. - Editorial: dissolve 2 <emu-xref> elements ... that should be handled by ecmarkup's auto-linking. - Markup: Use conventional format for clause-ids (for clauses relating to RegExp String Iterator Object + Instances) - Editorial: Define %RegExpStringIteratorPrototype% like other intrinsics - Editorial: Insert space before square-bracket ... in "%RegExpStringIteratorPrototype% [ @@toStringTag ]" - Editorial: Hoist "Properties of RegExp String Iterator Instances" clause Move it 'up' one level (pop it out of "The %RegExpStringIteratorPrototype% Object" clause), because it's not defining a property of %RegExpStringIteratorPrototype%. - Markup: Tweak "Internal Slots of RegExp String Iterator Instances" table. Change <figure>/<figurecaption>/<span> to <emu-table>. Change the id from "table-1" to something more mnemonic. Delete spurious "<tr>" tag. Refer to it with an <emu-xref> rather than an <a> element. (Originally, these were 11 separate commits, but @ljharb requested that I collapse them.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(tc39/proposal-string-matchall#21)