Don't explicitly set font/line-height on body, inherit from html instead#2729
Merged
adamwathan merged 1 commit intomasterfrom Nov 4, 2020
Merged
Don't explicitly set font/line-height on body, inherit from html instead#2729adamwathan merged 1 commit intomasterfrom
adamwathan merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2729 +/- ##
=======================================
Coverage 93.03% 93.03%
=======================================
Files 172 172
Lines 1737 1737
Branches 312 312
=======================================
Hits 1616 1616
Misses 104 104
Partials 17 17 Continue to review full report at Codecov.
|
philipp-spiess
added a commit
that referenced
this pull request
Mar 18, 2025
It was added in #2729 to override line heights set on the body by modern-normalize. However, it appears that modern-normalize never included any line-height definitions—only a font-family rule was present. Ref: https://github.com/sindresorhus/modern-normalize/blob/v1.1.0/modern-normalize.css --------- Co-authored-by: Philipp Spiess <hello@philippspiess.com>
tongrow
pushed a commit
to tongrow/tailwind-normalize
that referenced
this pull request
Jun 2, 2025
It was added in tailwindlabs#2729 to override line heights set on the body by modern-normalize. However, it appears that modern-normalize never included any line-height definitions—only a font-family rule was present. Ref: https://github.com/sindresorhus/modern-normalize/blob/v1.1.0/modern-normalize.css --------- Co-authored-by: Philipp Spiess <hello@philippspiess.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were setting the font and line-height on the
bodytag explicitly because of an override tobodyhappening in modern-normalize, but I think this is actually a simpler change and makes things behave more like people expect coming from Tailwind v1.x.