Remove redundant line-height from body#15212
Merged
philipp-spiess merged 2 commits intotailwindlabs:mainfrom Mar 18, 2025
Merged
Remove redundant line-height from body#15212philipp-spiess merged 2 commits intotailwindlabs:mainfrom
line-height from body#15212philipp-spiess merged 2 commits intotailwindlabs:mainfrom
Conversation
Contributor
Maybe I misunderstand something but there's a line-height rule here: https://github.com/sindresorhus/modern-normalize/blob/v1.1.0/modern-normalize.css#L33 |
Contributor
Author
|
Yup, and the |
73dd422 to
c08f9f3
Compare
philipp-spiess
approved these changes
Mar 18, 2025
tongrow
pushed a commit
to tongrow/tailwind-normalize
that referenced
this pull request
Jun 2, 2025
It was added in tailwindlabs#2729 to override line heights set on the body by modern-normalize. However, it appears that modern-normalize never included any line-height definitions—only a font-family rule was present. Ref: https://github.com/sindresorhus/modern-normalize/blob/v1.1.0/modern-normalize.css --------- Co-authored-by: Philipp Spiess <hello@philippspiess.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was added in #2729 to override line heights set on the body by modern-normalize. However, it appears that modern-normalize never included any line-height definitions—only a font-family rule was present.
Ref: https://github.com/sindresorhus/modern-normalize/blob/v1.1.0/modern-normalize.css