clientupdate: do not recursively delete dirs in cleanupOldDownloads#10093
Merged
tylersmalley merged 1 commit intomainfrom Nov 2, 2023
Merged
clientupdate: do not recursively delete dirs in cleanupOldDownloads#10093tylersmalley merged 1 commit intomainfrom
tylersmalley merged 1 commit intomainfrom
Conversation
bradfitz
reviewed
Nov 2, 2023
46d183b to
e6c2ab5
Compare
tylersmalley
reviewed
Nov 2, 2023
e6c2ab5 to
53861ac
Compare
tylersmalley
approved these changes
Nov 2, 2023
bradfitz
approved these changes
Nov 2, 2023
53861ac to
69db97a
Compare
In case there's a wild symlink in one of the target paths, we don't want to accidentally delete too much. Limit `cleanupOldDownloads` to deleting individual files only. Updates #10082 Signed-off-by: Andrew Lytvynov <awly@tailscale.com>
69db97a to
696c309
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case there's a wild symlink in one of the target paths, we don't want to accidentally delete too much. Limit
cleanupOldDownloadsto deleting individual files only.Updates #10082