clientupdate: cleanup SPK and MSI downloads#10085
Merged
Conversation
After we're done installing, clean up the temp files. This prevents temp volumes from filling up on hosts that don't reboot often. Fixes #10082 Signed-off-by: Andrew Lytvynov <awly@tailscale.com>
9c302e0 to
dd91d26
Compare
tendstofortytwo
approved these changes
Nov 2, 2023
Member
tendstofortytwo
left a comment
There was a problem hiding this comment.
Tested SPK cleanup, works
bradfitz
reviewed
Nov 2, 2023
| return | ||
| } | ||
| for _, m := range matches { | ||
| if err := os.RemoveAll(m); err != nil { |
Member
There was a problem hiding this comment.
what if I make a symlink in /tmp/ named /tmp/tailscale-update-foo pointing to /? will this delete the whole world recursively as root?
tylersmalley
pushed a commit
that referenced
this pull request
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After we're done installing, clean up the temp files. This prevents temp volumes from filling up on hosts that don't reboot often.
Fixes #10082