Skip to content

core: link user keyring to session keyring#6275

Merged
poettering merged 1 commit intosystemd:masterfrom
eworm-de:keyring-link
Jul 4, 2017
Merged

core: link user keyring to session keyring#6275
poettering merged 1 commit intosystemd:masterfrom
eworm-de:keyring-link

Conversation

@eworm-de
Copy link
Copy Markdown
Contributor

@eworm-de eworm-de commented Jul 3, 2017

Commit 74dd6b5 (core: run each system
service with a fresh session keyring) broke adding keys to user keyring.
Added keys could not be accessed with error message:

keyctl_read_alloc: Permission denied

So link the user keyring to our session keyring.

Commit  74dd6b5 (core: run each system
service with a fresh session keyring) broke adding keys to user keyring.
Added keys could not be accessed with error message:

keyctl_read_alloc: Permission denied

So link the user keyring to our session keyring.
@eworm-de
Copy link
Copy Markdown
Contributor Author

eworm-de commented Jul 3, 2017

This fixes #5522 and supersedes #6145.

@poettering
Copy link
Copy Markdown
Member

lgtm

@poettering poettering added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed pid1 labels Jul 3, 2017
@poettering poettering added this to the v234 milestone Jul 3, 2017
@poettering poettering merged commit 437a851 into systemd:master Jul 4, 2017
@poettering poettering mentioned this pull request Jul 4, 2017
2 tasks
@eworm-de eworm-de deleted the keyring-link branch July 4, 2017 10:05
eworm-de added a commit to eworm-de/systemd that referenced this pull request Jul 4, 2017
Commit  74dd6b5 (core: run each system
service with a fresh session keyring) broke adding keys to default
keyrings.
Added keys could not be accessed with error message:

keyctl_read_alloc: Permission denied

Commit 437a851 (core: link user keyring
to session keyring (systemd#6275)) fixed this for the user keyring.

Link the user session keyring as well.
eworm-de added a commit to eworm-de/systemd that referenced this pull request Jul 4, 2017
Commit  74dd6b5 (core: run each system
service with a fresh session keyring) broke adding keys to default
keyrings.
Added keys could not be accessed with error message:

keyctl_read_alloc: Permission denied

Commit 437a851 (core: link user keyring
to session keyring (systemd#6275)) fixed this for the user keyring.

Link the user session keyring as well.
eworm-de added a commit to eworm-de/systemd that referenced this pull request Jul 5, 2017
Commit  74dd6b5 (core: run each system
service with a fresh session keyring) broke adding keys to default
keyrings.
Added keys could not be accessed with error message:

keyctl_read_alloc: Permission denied

Commit 437a851 (core: link user keyring
to session keyring (systemd#6275)) fixed this for the user keyring.

Link the user session keyring as well.
poettering added a commit to poettering/systemd that referenced this pull request Jul 12, 2017
This reverts commit 437a851.

The outcome of this isn't that clear, let's revert this for now, see
discussion on systemd#6286.
keszybz pushed a commit that referenced this pull request Jul 12, 2017
This reverts commit 437a851.

The outcome of this isn't that clear, let's revert this for now, see
discussion on #6286.
eumpf0 pushed a commit to eumpf0/systemd that referenced this pull request Dec 31, 2023
  to version (233.75 -> release 233, 75 stable commits)
  -> We keep both, systemd-stable (for stable branches with cherry-picked
     commits) and systemd (for release tags and source verification).
  -> drop upstream commit from our backports
* apply: core: do not print color console message about gc-ed jobs
* update to upstream keyring fix: core: link user keyring to session
  keyring (systemd#6275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed pid1

Development

Successfully merging this pull request may close these issues.

2 participants