lib/ignore: Refactor out result type #9343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves Result into a package of its own and cleans up the related naming a bit. The ShouldIgnore() method goes away, instead callers use the Match() method directly. This enables the work in syncthing#9339.
imsodin
reviewed
Jan 13, 2024
Comment on lines
16
to
17
| // The bit flags are used by the ignore package to construct Results. | ||
| // Don't use them for comparison; use the convenience methods. |
Member
There was a problem hiding this comment.
Could we get setters or a constructor for the result to use in ignore to avoid this?
imsodin
approved these changes
Jan 13, 2024
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Jan 14, 2024
* main: (24 commits) lib/ignore: Refactor out result type (syncthing#9343) build: Testing infra images for infra-* branches lib/versioner: Expand tildes in version directory (fixes syncthing#9241) (syncthing#9327) lib/scanner: Prevent sync-conflict for receive-only local modifications (syncthing#9323) gui, man, authors: Update docs, translations, and contributors Fix website security link in README.md (syncthing#9325) cmd/syncthing: Add CLI completion functionality (fixes syncthing#8616) (syncthing#9226) lib/api: Save session & CSRF tokens to database, add option to stay logged in (fixes syncthing#9151) (syncthing#9284) Update dependencies (syncthing#9321) gui: Always inform about loading data in Restore Versions modal (syncthing#9317) lib/build: Allow semver build in version regex (fixes syncthing#9267) (syncthing#9316) gui: Keep short deviceID length consistent + xrefs (fixes syncthing#9313) (syncthing#9314) build(deps): bump actions/download-artifact from 3 to 4 (syncthing#9294) build(deps): bump actions/upload-artifact from 3 to 4 (syncthing#9293) gui, man, authors: Update docs, translations, and contributors gui, lib/scanner: Improve scan progress indication (ref syncthing#8331) (syncthing#9308) lib/protocol: handle empty names in unixOwnershipEqual (fixes syncthing#9039) (syncthing#9306) gui, man, authors: Update docs, translations, and contributors etc/linux-desktop: use double dash for long options (syncthing#9301) lib/connections: Skip allocation in check for missing port (syncthing#9297) ...
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Feb 2, 2024
* main: lib/model: Typo in method name (fixes syncthing#9389) lib/model: Typo in debug print (fixes syncthing#9386) build: Update dependencies (syncthing#9379) build(deps): bump actions/cache from 3 to 4 (syncthing#9363) lib/api: Improve folder summary event, verbose service (syncthing#9370) lib/protocol: Refactor interface (syncthing#9375) gui, man, authors: Update docs, translations, and contributors lib/fs: Add invalid UTF-8 guards to watcher (fixes syncthing#9369) (syncthing#9372) lib/api: Remove remnants of CSRF tokens file mentions (ref syncthing#9284) gui, man, authors: Update docs, translations, and contributors gui: Remove non-functional HTML from External Versioning tooltip (ref syncthing#8923) (syncthing#9358) cmd/ursrv: Add FreeBSD detection (syncthing#9351) cmd/ursrv: Fix Arch detection (syncthing#9350) lib/ignore: Optimise ignoring directories for filesystem watcher (fixes syncthing#9339) (syncthing#9340) gui, man, authors: Update docs, translations, and contributors lib/ignore: Refactor out result type (syncthing#9343)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves Result into a package of its own and cleans up the related naming a bit. The ShouldIgnore() method goes away, instead callers use the Match() method directly.
This enables the work in #9339.