Allow BindDN to exclude any username formatting #8900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a syncthing instance to be locked to exactly 1 user without needing search capability on the LDAP instance.
acolomb
approved these changes
May 10, 2023
Member
acolomb
left a comment
There was a problem hiding this comment.
Nice fix, looks all good though I haven't tested it.
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Jun 4, 2023
* main: gui: Remove HTML support in tooltips cmd/syncthing: Use correct binary when restarting monitor (syncthing#8919) build(deps): bump github.com/minio/sha256-simd from 1.0.0 to 1.0.1 (syncthing#8916) build: Increase concurrency, add "basic checks" gatekeeper gui, man, authors: Update docs, translations, and contributors gui, man, authors: Update docs, translations, and contributors lib/model: Set platform data for new folders w/ ignorePerms (ref syncthing#8883) (syncthing#8907) gui, man, authors: Update docs, translations, and contributors lib: replace `Readdir(-1)` with `os.ReadDir` (syncthing#8901) lib/api: Allow BindDN to exclude any username formatting (fixes syncthing#8899) (syncthing#8900) build: Attempt cross compilation for ~all targets, allow it to fail lib/fs: Fix root path handling for Windows (fixes syncthing#8778) all: Grand test refactor (fixes syncthing#8779, fixes syncthing#8799) all: Correct various typos (syncthing#8870)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the error string being injected when the template variable for username is omitted in the LDAP Bind DN string (fixes #8899).
Testing
Regression tests have been added to check the new behavior for the original use case and the new one.
Documentation
No documentation change should be required, although the language for LDAP configuration could be changed to note that
%sis optional. This would be in-line with the more useful use LDAP auth, which is locking a single syncthing instance to a single user account which manages it's password via LDAP.