Omitting %s from LDAP bind DN sends corrupted bind DN string to LDAP server #8899
Description
Syncthing Version
Syncthing version: v1.23.4, Linux (64-bit Intel/AMD Container)
What Happened
Configuring LDAP auth with a bind DN which omits the %s placeholder (to restrict login to a specific user with LDAP) results in the following bind DN being sent to LDAP:
So configuring
cn=will,dc=home,dc=internal
results in the following being sent to the LDAP server
cn=will,dc=home,dc=internal%!(extra string=will)
Which obviously fails.
What Is Expected
If the %s is omitted, the the bind DN will be sent as-is to the LDAP server.
Reproduction
- Configure a bind DN without a
%splaceholder - Enable LDAP auth
- Observe the logs on the LDAP auth attempt