Skip to content

Conversation

@kbdharun
Copy link
Contributor

Purpose

This PR fixes the Node 12 deprecation shown under the action runs of update-docs-translations.yaml by bumping the version of actions/checkout from v2 (Node 12) to v3 (Node 16).

This PR also updates actions/setup-go to v4.

Closes #8832

Testing

These changes haven't been tested yet, but they are non-breaking changes.

@calmh
Copy link
Member

calmh commented Apr 28, 2023

I wasn't allowed to push changes to your PR branch, but if you merge with main there's one more setup-go that needs fixing now. Sorry about that.

@kbdharun
Copy link
Contributor Author

I wasn't allowed to push changes to your PR branch, but if you merge with main there's one more setup-go that needs fixing now. Sorry about that.

Sure, I will try merging with main now.

@calmh
Copy link
Member

calmh commented Apr 29, 2023

Right, now if you peek at build-syncthing.yaml you'll see there's an additional actions/setup-go@v3 that could be fixes in this same PR :)

@kbdharun
Copy link
Contributor Author

kbdharun commented Apr 29, 2023

Right, now if you peek at build-syncthing.yaml you'll see there's an additional actions/setup-go@v3 that could be fixes in this same PR :)

Noted, I will update it.

Update: Done :)

@calmh calmh merged commit f38e962 into syncthing:main Apr 29, 2023
calmh added a commit to calmh/syncthing that referenced this pull request May 3, 2023
* main:
  lib/model: Set platform data, incl. copying ownership, for new folders w/ NoPermissions flag (syncthing#8883)
  gui: Add Thai (th) translation template. (syncthing#8887)
  build: Produce nightly release builds
  gui, man, authors: Update docs, translations, and contributors
  build: Bump actions version; fix Node 12 deprecation warning (syncthing#8881)
  build: Build Debian packages
  build: Sign for upgrades
  build: Notarize mac builds
calmh added a commit to calmh/syncthing that referenced this pull request May 9, 2023
* main: (42 commits)
  all: Correct various typos (syncthing#8870)
  gui, man, authors: Update docs, translations, and contributors
  lib/model: Set platform data, incl. copying ownership, for new folders w/ NoPermissions flag (syncthing#8883)
  gui: Add Thai (th) translation template. (syncthing#8887)
  build: Produce nightly release builds
  gui, man, authors: Update docs, translations, and contributors
  build: Bump actions version; fix Node 12 deprecation warning (syncthing#8881)
  build: Build Debian packages
  build: Sign for upgrades
  build: Notarize mac builds
  build(deps): bump github.com/quic-go/quic-go from 0.33.0 to 0.34.0 (syncthing#8877)
  gui, man, authors: Update docs, translations, and contributors
  lib/ignore: Properly handle non-existing included ignore-files (fixes syncthing#8764) (syncthing#8874)
  lib/connections: Avoid using nil lanChecker
  gui, man, authors: Update docs, translations, and contributors
  lib/config, lib/connections: Configurable protocol priority (ref syncthing#8626) (syncthing#8868)
  build: Upgrade recli (fixes syncthing#8503) (syncthing#8871)
  build: Update dependencies (syncthing#8869)
  lib/model: Improve path generation for auto accepted folders (fixes syncthing#8859) (syncthing#8860)
  docs: fix typo (syncthing#8857)
  ...
@calmh calmh added this to the v1.23.5 milestone May 9, 2023
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Apr 28, 2024
@syncthing syncthing locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants