Updating library/bundle install docs to use "require"#4290
Merged
weaverryan merged 4 commits into2.3from Oct 18, 2014
Merged
Conversation
…uire (no version) functionality
cookbook/bundles/installation.rst
Outdated
Member
There was a problem hiding this comment.
must be changed to _KnpBundles.com
Member
|
👎 for the reason I mentioned here: #4267 (comment) |
Member
|
@wouterj this is a case against using |
Member
|
@stof indeed. This PR does 2 things:
I'm +1 for (1) and -1 for (2). |
Contributor
Author
|
Hi guys! I agree with Wouter, so I've re-added the version back on several places. When we're giving people docs on how to use a library, then we should have a version, just in case they come out with a new version that's incompatible with our docs. But in other places, if we're just saying "you can install this library" and provide no other details, then I don't think we need the version there. I've updated the PR to reflect that and am merging it in. Thanks! |
weaverryan
added a commit
that referenced
this pull request
Oct 18, 2014
…weaverryan) This PR was merged into the 2.3 branch. Discussion ---------- Updating library/bundle install docs to use "require" | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | - As of composer/composer#3906, you can now simply install a library via: ``` php composer.phar require myname/my-lib ``` The latest version if chosen for you. I've replaced all mentions of modifying composer.json and running `composer update` with using the `require` command. I think the result is much simpler :). Thanks! Commits ------- d7ccbf3 Re-adding one more version ab2a688 [#4290] Re-adding version back a174a2b Fixing bad link 1a7c4b9 Updating library/bundle installation docs to use the new composer require (no version) functionality
weaverryan
added a commit
that referenced
this pull request
Oct 18, 2014
* 2.3: Putting #pull-request-format anchor link back, which we link to in our contrib notes Re-adding one more version [#4290] Re-adding version back Fixing bad link Updating library/bundle installation docs to use the new composer require (no version) functionality Conflicts: components/dependency_injection/lazy_services.rst cookbook/bundles/installation.rst
weaverryan
added a commit
that referenced
this pull request
Oct 18, 2014
* 2.5: Putting #pull-request-format anchor link back, which we link to in our contrib notes Re-adding one more version [#4290] Re-adding version back Fixing bad link Updating library/bundle installation docs to use the new composer require (no version) functionality [#4233][#4094] Making validateValue and validate changes Minor tweaks and a missing location thanks to xabbuh and WouterJ Fixes thanks to @xabbuh Adding a section about keeping BC in a re-usable bundle Adding details about the 2.4 API as comments added a versionadded comment to Callback.rst Update custom_contraint.rst to meet the new 2.5 api Don't use deprecated functions in Callback.rst Update Callback.rst Replace addViolationAt (deprecated) by buildViolation
wouterj
added a commit
that referenced
this pull request
Oct 26, 2014
* Added interlinking between the application bundles best practices and this article (which is about reusable bundles) * Readded the version. It seems like this one was missed when reverting ([ref](#4290))
wouterj
added a commit
to wouterj/symfony-docs
that referenced
this pull request
Oct 26, 2014
It seems like this one was missed when reverting the change. For the discussion, see symfony#4290
wouterj
added a commit
to wouterj/symfony-docs
that referenced
this pull request
Oct 31, 2014
It seems like this one was missed when reverting the change. For the discussion, see symfony#4290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of composer/composer#3906, you can now simply install a library via:
The latest version if chosen for you. I've replaced all mentions of modifying composer.json and running
composer updatewith using therequirecommand. I think the result is much simpler :).Thanks!