Conversation
|
Please add a note in the bundle best practices sayignt hat shared bundles MUST support both the 2.4 and the 2.5 validation API, given they don't know which one is used in a project. An example should be provided showing how to do it |
|
bundle best practices": public bundle (vs project bundle.) |
|
The cookbook chapter about form testing should probably also be updated (see for example the changes in #4213). What do you think? |
|
Thanks for the feedback! I've just added a section to the bundle best-practices doc, which could use a quick review. |
There was a problem hiding this comment.
I would add a use statement for this class. (and for all 3 classes used in this example actually)
"Symfony\Component\Validator\ExecutionContextInterface" namespace is deprecated, new namespace should be "Symfony\Component\Validator\Context\ExecutionContextInterface"
The addViolationAt function is marked as deprecated and should be replaced by buildViolation according to the Symfony update guides.
baeae98 to
94fc520
Compare
|
Hi guys! I made a few tweaks (including updating the form testing chapter) at sha: 94fc520 and then also tackled the changes to One last review would be awesome because these changes are confusing, so I want them to be perfect in the docs. Thanks! |
…, weaverryan) This PR was merged into the 2.5 branch. Discussion ---------- 2.5 Validation API changes | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.5 | Fixed tickets | #4094 Hi guys! This takes the work in #4056, #4105 and #4161 and extends it based on some feedback. Basically, the whole validation stuff is quite difficult, because: A) We want to show the non-deprecated methods so people use the new stuff B) We don't want to confuse users on the 2.4 API (even though this number of users should be very small, as it would require you to have started a project in the past and be using 5.3.9 and lower #4105 (comment)) This solution is to show the new way, but always show the old way in comments. This would check of A and B in #4094. Thanks! Commits ------- 9874d8e [#4233][#4094] Making validateValue and validate changes 94fc520 Minor tweaks and a missing location thanks to xabbuh and WouterJ f97ba7a Fixes thanks to @xabbuh 279d8d6 Adding a section about keeping BC in a re-usable bundle 280440e Adding details about the 2.4 API as comments e658b56 added a versionadded comment to Callback.rst 70c5ca1 Update custom_contraint.rst to meet the new 2.5 api 5dfe499 Don't use deprecated functions in Callback.rst f4380ed Update Callback.rst 042dcf9 Replace addViolationAt (deprecated) by buildViolation
* 2.5: Putting #pull-request-format anchor link back, which we link to in our contrib notes Re-adding one more version [#4290] Re-adding version back Fixing bad link Updating library/bundle installation docs to use the new composer require (no version) functionality [#4233][#4094] Making validateValue and validate changes Minor tweaks and a missing location thanks to xabbuh and WouterJ Fixes thanks to @xabbuh Adding a section about keeping BC in a re-usable bundle Adding details about the 2.4 API as comments added a versionadded comment to Callback.rst Update custom_contraint.rst to meet the new 2.5 api Don't use deprecated functions in Callback.rst Update Callback.rst Replace addViolationAt (deprecated) by buildViolation
Hi guys!
This takes the work in #4056, #4105 and #4161 and extends it based on some feedback. Basically, the whole validation stuff is quite difficult, because:
A) We want to show the non-deprecated methods so people use the new stuff
B) We don't want to confuse users on the 2.4 API (even though this number of users should be very small, as it would require you to have started a project in the past and be using 5.3.9 and lower #4105 (comment))
This solution is to show the new way, but always show the old way in comments. This would check of A and B in #4094.
Thanks!