[3.0][HttpKernel] remove deprecated functions and classes by vincentaubert · Pull Request #14634 · symfony/symfony

vincentaubert · 2015-05-14T13:29:32Z

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

vincentaubert · 2015-05-14T13:33:27Z

Hello,

I have a problem with the dependency injection of the Framework bundle.

in the services.xml file in the framework bundle I got this :

<service id="http_kernel" class="Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel">
            <argument type="service" id="event_dispatcher" />
            <argument type="service" id="service_container" />
            <argument type="service" id="controller_resolver" />
            <argument type="service" id="request_stack" />
        </service>

But the Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel class is marked as deprecated in the HttpKernel component.

By what should I replace this class to make it work ?

Thanks

xabbuh · 2015-05-14T14:07:14Z

@vincentaubert You can use Symfony\Component\HttpKernel\HttpKernel instead.

dosten · 2015-05-14T14:08:01Z

You should replace it by Symfony\Component\HttpKernel\HttpKernel and remove <argument type="service" id="service_container" /> from the definition.

vincentaubert · 2015-05-14T15:03:14Z

Thanks

fabpot · 2015-05-14T15:11:37Z

src/Symfony/Bridge/Doctrine/Tests/Logger/DbalLoggerTest.php

This change and the next one should happen in Symfony 2.7 instead.

done in PR #14637

vincentaubert · 2015-05-14T21:39:42Z

ping @symfony/mergers

This PR is ready for merge.

The 2 failing tests have been fixed in the 2.7 branch via the #14637 PR but the 2.7 branch hasn't been merged in master at the moment.

I launched the tests locally with the patch and all the tests passed

dosten · 2015-05-15T04:04:41Z

ProfilerListener::getSubscribedEvents() remove the KernelEvents::REQUEST => array('onKernelRequest', 1024), line and the comments above.

vincentaubert · 2015-05-15T06:57:22Z

fixed thanks

nicolas-grekas · 2015-05-15T11:12:44Z

src/Symfony/Component/HttpKernel/DataCollector/DumpDataCollector.php

if to be removed also

vincentaubert · 2015-05-15T14:20:04Z

done and code rebased on the latest master

nicolas-grekas · 2015-05-15T14:42:52Z

src/Symfony/Component/HttpKernel/DataCollector/DumpDataCollector.php

You should keep this line!

fabpot · 2015-05-16T12:30:08Z

Thank you @vincentaubert.

…ses (vincentaubert) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0][HttpKernel] remove deprecated functions and classes | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- c19f918 [3.0][HttpKernel] remove deprecated functions and classes

Tobion · 2015-05-19T11:05:17Z

src/Symfony/Component/HttpKernel/EventListener/RouterListener.php

requestStack must be made required

…derrabus) This PR was submitted for the master branch but it was merged into the 3.0 branch instead (closes #225). Discussion ---------- Don't include ContainerAwareHttpKernel if it's not present When generating the bootstrap file, the composer script handler also includes `Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel`, a class that has been removed with PR symfony/symfony#14634 and that will be gone in Symfony 3.0. This pull request checks if the class is present and includes `Symfony\Component\HttpKernel\HttpKernel` otherwise. The code should work with Symfony 2.7 as well as with 3.0-dev. Commits ------- 2e45487 Don't include ContainerAwareHttpKernel if it's not present.

…ion) This PR was merged into the 3.0-dev branch. Discussion ---------- [HttpKernel] make RequestStack parameter required | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Continuation of #14634, #8904 Commits ------- a2e154d [HttpKernel] make RequestStack parameter required for classes that need it

vincentaubert force-pushed the master_remove_deprecation_httpKernel branch from 38c523c to d98acac Compare May 14, 2015 13:43

fabpot reviewed May 14, 2015
View reviewed changes

vincentaubert force-pushed the master_remove_deprecation_httpKernel branch 3 times, most recently from aaf7e51 to fcfdafa Compare May 14, 2015 18:19

vincentaubert force-pushed the master_remove_deprecation_httpKernel branch from fcfdafa to 1195613 Compare May 15, 2015 06:57

nicolas-grekas reviewed May 15, 2015
View reviewed changes

src/Symfony/Component/HttpKernel/DataCollector/DumpDataCollector.php Outdated

Copy link
Copy Markdown

Member

nicolas-grekas May 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if to be removed also

vincentaubert force-pushed the master_remove_deprecation_httpKernel branch from 1195613 to 2a29119 Compare May 15, 2015 14:19

nicolas-grekas reviewed May 15, 2015
View reviewed changes

vincentaubert force-pushed the master_remove_deprecation_httpKernel branch from 2a29119 to 5bf6b0d Compare May 15, 2015 15:24

[3.0][HttpKernel] remove deprecated functions and classes

c19f918

vincentaubert force-pushed the master_remove_deprecation_httpKernel branch from 336016c to c19f918 Compare May 16, 2015 08:02

fabpot merged commit c19f918 into symfony:master May 16, 2015

vincentaubert deleted the master_remove_deprecation_httpKernel branch May 16, 2015 13:38

Tobion reviewed May 19, 2015
View reviewed changes

src/Symfony/Component/HttpKernel/EventListener/RouterListener.php

Copy link
Copy Markdown

Contributor

Tobion May 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requestStack must be made required

Tobion mentioned this pull request Jul 3, 2015

[HttpKernel] make RequestStack parameter required #15196

Merged

derrabus mentioned this pull request Sep 15, 2015

Don't include ContainerAwareHttpKernel if it's not present sensiolabs/SensioDistributionBundle#225

Closed

Uh oh!

Conversation

vincentaubert commented May 14, 2015

Uh oh!

vincentaubert commented May 14, 2015

Uh oh!

xabbuh commented May 14, 2015

Uh oh!

dosten commented May 14, 2015

Uh oh!

vincentaubert commented May 14, 2015

Uh oh!

fabpot May 14, 2015

Choose a reason for hiding this comment

Uh oh!

vincentaubert May 14, 2015

Choose a reason for hiding this comment

Uh oh!

vincentaubert commented May 14, 2015

Uh oh!

dosten commented May 15, 2015

Uh oh!

vincentaubert commented May 15, 2015

Uh oh!

nicolas-grekas May 15, 2015

Choose a reason for hiding this comment

Uh oh!

vincentaubert commented May 15, 2015

Uh oh!

nicolas-grekas May 15, 2015

Choose a reason for hiding this comment

Uh oh!

vincentaubert May 15, 2015

Choose a reason for hiding this comment

Uh oh!

fabpot commented May 16, 2015

Uh oh!

Tobion May 19, 2015

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants