This repository was archived by the owner on Jan 6, 2020. It is now read-only.
Don't include ContainerAwareHttpKernel if it's not present#225
Closed
derrabus wants to merge 1 commit intosensiolabs:masterfrom
derrabus:no-container-aware-http-kernel
Closed
Don't include ContainerAwareHttpKernel if it's not present#225derrabus wants to merge 1 commit intosensiolabs:masterfrom derrabus:no-container-aware-http-kernel
derrabus wants to merge 1 commit intosensiolabs:masterfrom
derrabus:no-container-aware-http-kernel
Conversation
Member
|
Thank you @derrabus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating the bootstrap file, the composer script handler also includes
Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel, a class that has been removed with PR symfony/symfony#14634 and that will be gone in Symfony 3.0.This pull request checks if the class is present and includes
Symfony\Component\HttpKernel\HttpKernelotherwise. The code should work with Symfony 2.7 as well as with 3.0-dev.