[CSSimplify] Narrow down tuple wrapping for pack expansion matching#82467
Merged
Conversation
Follow-up for swiftlang#82326. The optional injection is only viable is the wrapped type is not yet resolved, otherwise it's safe to wrap the optional.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please build toolchain macOS |
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Jun 24, 2025
Contributor
Author
|
@swift-ci please clean test Linux platform |
Contributor
Author
|
@swift-ci please test Linux platform |
2 similar comments
Contributor
Author
|
@swift-ci please test Linux platform |
Contributor
Author
|
@swift-ci please test Linux platform |
Contributor
Author
|
@swift-ci please smoke test Linux platform |
hamishknight
approved these changes
Jun 25, 2025
| guard let _ = try? test1(1, 2, v) else { return } // Ok | ||
|
|
||
| guard let _ = try? test2(1, 2, 3) else { return } // Ok | ||
| guard let _ = try? test2(1, 2, v) else { return } // Ok |
Contributor
There was a problem hiding this comment.
Presumably this means that this also fails if v is Any?
Contributor
Author
There was a problem hiding this comment.
Yeah, this is an existing problem since we cannot decide what to do in this case early on.
Contributor
Author
|
swiftlang/swift-package-manager#8872 |
Contributor
Author
|
swiftlang/swift-package-manager#8874 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #82326.
The optional injection is only viable is the wrapped type is not yet resolved, otherwise it's safe to wrap the optional.
Resolves: rdar://154221449