[CSSimplify] VariadicGenerics: Don't attempt to wrap optional into on…#82326
Merged
Conversation
…e-element tuple If we have a tuple with unresolved pack expansion on one side and an optional type on the other, prevent `matchTypes` from wrapping optional into a one-element tuple because the matching should be handled as part of the optional injection. Resolves: rdar://152940244
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS platform |
Contributor
Author
|
@swift-ci please test Windows platform |
1 similar comment
Contributor
Author
|
@swift-ci please test Windows platform |
hamishknight
approved these changes
Jun 19, 2025
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jun 24, 2025
Follow-up for swiftlang#82326. The optional injection is only viable is the wrapped type is not yet resolved, otherwise it's safe to wrap the optional.
Merged
2 tasks
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jun 25, 2025
Follow-up for swiftlang#82326. The optional injection is only viable is the wrapped type is not yet resolved, otherwise it's safe to wrap the optional. (cherry picked from commit 4804f21)
This was referenced Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e-element tuple
If we have a tuple with unresolved pack expansion on one side and an optional type on the other, prevent
matchTypesfrom wrapping optional into a one-element tuple because the matching should be handled as part of the optional injection.Resolves: rdar://152940244
Resolves #82487