Cherry-Pick -enable-swifttail-musttail-check flag#3016
Merged
etcwilde merged 3 commits intoswiftlang:swift/nextfrom Jun 7, 2021
Merged
Conversation
Fixes rdar://76024125.
… calls. When -enable-swifttailcc-musttail-check is passed (off by default), we will check that all swiftasync->swiftasync tail calls are marked musttail. Fixes rdar://75899279.
varungandhi-apple
approved these changes
May 28, 2021
varungandhi-apple
left a comment
There was a problem hiding this comment.
Shouldn't this have come in through an automerger? I'm surprised as to why next needs to updated manually for this flag...
|
Ah, nvm, I originally landed it on apple/stable, and there's no automerger from there to next. |
|
There's one more change related to this though with NDEBUG. |
|
#3004 <- You can cherry-pick this too for consistency. |
Member
Author
That's why I requested your review. Thanks for noting that. |
Member
Author
Commit cherry-picked. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #2766 onto the swift/next branch.
Resolves: rdar://78628967