[lldb][swift] Use dynamic types as a fallback in AddVariableInfo#2031
Merged
Teemperor merged 1 commit intoswiftlang:swift/mainfrom Oct 26, 2020
Merged
[lldb][swift] Use dynamic types as a fallback in AddVariableInfo#2031Teemperor merged 1 commit intoswiftlang:swift/mainfrom
Teemperor merged 1 commit intoswiftlang:swift/mainfrom
Conversation
Since commit eaceb46 AddVariableInfo is always using the dynamic type if requested. The dynamic types appear to not always be usable and caused a few tests to fail(1), but as the swiftTest decorator was always skipping all Swift tests since commit 2c911bc this wasn't discovered before landing. This patch restores the old behaviour where possible by first trying the non-dynamic type and falling back to the dynamic type in case the non-dynamic type can't be fully realized. (1) All the failures seem to be related to us reading corrupt data from memory when using the dynamic type in the expression parser. The dynamic types itself appear to be perfectly fine, so it's not clear why the new behaviour doesn't work.
Author
|
@swift-ci test |
adrian-prantl
approved these changes
Oct 23, 2020
adrian-prantl
left a comment
There was a problem hiding this comment.
That's fascinating. I need to dig deeper here to figure out why the dynamic type sometimes isn't useable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit eaceb46 AddVariableInfo is
always using the dynamic type if requested. The dynamic types appear
to not always be usable and caused a few tests to fail(1), but as the swiftTest
decorator was always skipping all Swift tests since commit
2c911bc this wasn't discovered before landing.
This patch restores the old behaviour where possible by first trying the
non-dynamic type and falling back to the dynamic type in case the non-dynamic
type can't be fully realized.
(1) All the failures seem to be related to us reading corrupt data from memory
when using the dynamic type in the expression parser. The dynamic types itself
appear to be perfectly fine, so it's not clear why the new behaviour doesn't work.