-
-
Notifications
You must be signed in to change notification settings - Fork 807
Merging new styles and documentation #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this bundle is used also for browsecast-less presentations and thus browsercast should not unbind the space in this case and that's solved now
fix #26: updated bundled deck.js, including the fix on browsercast
1. Renaming Ruby file to use underscore in name (consistent with other `bin` scripts). 2. Generating `_includes/all_figures.html` for the first time when creating a new lesson.
add tools to deal with episodes written in Rmd
Fix Rmd formatting
1. Modify `read_markdown` to return list of (index, line, line_length). 2. Modify `lesson_check.py` to make line-length checking optional.
use anonymous function to generate markdown files
|
Thanks Greg for converting the lesson! One remark I have is regarding the times allocated to the lessons: as of now I think the schedule is overly ambitious. Here we usually cover material up to functions including command line programs in a full day. I think this varies widely on the students, instructor, number of exercises... Maybe we should explicitly state somewhere in the lesson that these times can be variable: I don't want instructors to start rushing for materials just because we fixed a lesson to 20 min. That I think applies to all lessons. There are still a few typos and inconsistencies which were left after the merges, so I put a list of all of them in one issue #287 (including some of my ideas for improvement). I could fix the simple stuff after the merge and leave more major modifications for the future. |
|
Hi Valentina,
Pull requests to make the times more realistic are very welcome - what's
in there now is mostly out-of-date guesswork. And yes, there should be
a note somewhere that times are provisional and advisory - what and
where do you think best?
Cheers,
Greg
|
|
We could add a footnote to the title Schedule, and below the actual schedule state something like The recommended schedule will vary depending on topics and exercises covered. or The schedule is provisional and will vary depending on topics and exercises covered. ? |
|
Sure - file a PR in the lesson-example repo and I'll fold it into the docs?
|
|
Merged. |
Add support for error class for R Markdown generated lessons
Add links.md to files in boilerplate
Merging new styles and documentation
This PR brings in all of the 2016-06 template, along with documentation on building lessons to create a new published version with the DOI 10.5281/zenodo.57492.