Use command line throughout whole command line lesson #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1.
|
Contributor
|
On Fri, Apr 17, 2015 at 08:35:23PM -0700, Damien Irving wrote:
The changes look good to me, but you shouldn't be contributing the |
Contributor
Author
|
Ah, thanks @wking - I should have read CONTRIBUTING.md more closely. Happy to re-submit the pull request without the .html file if the maintainers would prefer? |
Contributor
|
No worries about the .html files being included; it's better practice to not include them, but not a hard and fast rule. Thanks for these changes, big improvement IMO! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the command line lesson (
08-cmdline.html) begins by calling python scripts from within the IPython notebook (using%run script.pyor!ipython script.py) and then about half way through the lesson it switches to calling scripts from the command line itself (i.e.$ python script.py). This is very confusing for learners and instructors, so I'm proposing that we just use the command line from beginning to end (i.e. don't even open an IPython notebook for this lesson - just teach it entirely from the command line).This PR also fixes some little things towards the end of the lesson because no reference was made to
readings-05.pyorreadings-06.pyin the lesson notes.