-
-
Notifications
You must be signed in to change notification settings - Fork 807
glob.glob returns paths in arbitrary order. #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| The `glob` library contains a single function, also called `glob`, | ||
| that finds files whose names match a pattern. | ||
| The `glob` library contains a function, also called `glob`, | ||
| that finds files and directories whose names match a pattern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me this makes it sound like it will return directories in the list as well (like ls) rather than files and their paths. Can you come up with a clearer way to say this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glob.glob() does return both files and directories, not sure what you are asking me to clarify here.
|
This change was also proposed in #153; from that thread:
|
|
Could you make the comment as suggested by @gvwilson above, in a callout box? |
|
@tbekolay I like it as it is now, I see no need for a callout box. |
|
Hm, reading it over again it does look like a pretty minimal set of changes to introduce both |
|
Thanks for your contribution @nsoranzo! |
As a result of swcarpentry#246.
…-readings Changing preliminary readings
No description provided.