Skip to content

Conversation

@joannadiong
Copy link

Modification to numpy.md
I instructed a python workshop and only introduced the magic command % matplotlib inline after getting participants to run the section to show the heat map. I learned that on some computers (Macs, and a few Windows), the ipython notebook hangs if the magic command is not specified - a handful of participants were forced to shut down the notebook and restart. It would be helpful to include the magic command earlier when plotting the graphs to prevent notebooks from potentially hanging.

Modification to files.md
My machine runs on Linux Mint 17.2 (I am new to Linux). The print(glob.glob('inflammation*.csv')) command executed but produced a list of inflammation filenames that were out of numeric order. I checked with participants but it seems this behaviour only occurred on my machine. Everyone in that workshop was either running Windows or Mac so the problem may be OS dependent. It was easily fixed with by adding the sorted() option. This change could be considered for inclusion but it is not a major problem.

Thanks

@tbekolay
Copy link
Contributor

For the %matplotilb inline change, could you instead make a separate callout that gives some context on it and how it is used? Currently this lesson does not require the use of Jupyter notebooks, so we would like to keep Jupyter notebook-specific instructions in callouts so that people not using notebooks can quickly see that instructions are notebook specific and skip them.

#246 also contains the sorted fix; there have been several comments there about how best to explain why sorted is useful and when is best to mention it, so could you look there and update this PR accordingly? Alternatively, if you prefer, you can take the sorted part of this PR out and leave it to #246.

@gvwilson gvwilson closed this Jun 14, 2016
rgaiacs added a commit to rgaiacs/swc-python-novice-inflammation that referenced this pull request Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants