Skip to content

fix: do not dispatch transition event with animation#18122

Merged
Rich-Harris merged 3 commits into
sveltejs:mainfrom
dabund24:main
Apr 20, 2026
Merged

fix: do not dispatch transition event with animation#18122
Rich-Harris merged 3 commits into
sveltejs:mainfrom
dabund24:main

Conversation

@dabund24

@dabund24 dabund24 commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

closes #18056
related: #17567 and #14009

Changes

move dispatch_event() calls in transitions.js out of animate() function using an additional on_begin() callback parameter. Doing so makes it possible to dispatch the introstart and outrostart events only from transition().

Testing

add a test checking that svelte dispatches no event when it runs an animation

@changeset-bot

changeset-bot Bot commented Apr 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: be10223

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dabund24 dabund24 changed the title fix: no transition event fired with animation fix: do not dispatch transition event with animation Apr 17, 2026

@Rich-Harris Rich-Harris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Rich-Harris Rich-Harris merged commit 51736e5 into sveltejs:main Apr 20, 2026
17 of 18 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 20, 2026
elliott-with-the-longest-name-on-github pushed a commit that referenced this pull request Apr 23, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## svelte@5.55.5

### Patch Changes

- fix: don't mark deriveds while an effect is updating
([#18124](#18124))

- fix: do not dispatch introstart event with animation of animate
directive ([#18122](#18122))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

onintrostart dispatches with animate: animation

2 participants