fix: make onintrostart respect delay parameter#17567
Merged
Merged
Conversation
Fixes sveltejs#14009 The onintrostart event now fires after the delay period completes, rather than immediately when the transition is initiated. This ensures that the event accurately reflects when the intro animation actually starts. Changes: - Added on_start callback parameter to animate() function - Dispatch introstart event after delay animation finishes - Handle edge case where duration is 0 but delay > 0
🦋 Changeset detectedLatest commit: 2472adc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
Apr 20, 2026
closes #18056 related: #17567 and #14009 # Changes move `dispatch_event()` calls in `transitions.js` out of `animate()` function using an additional `on_begin()` callback parameter. Doing so makes it possible to dispatch the `introstart` and `outrostart` events only from `transition()`. # Testing add a test checking that svelte dispatches no event when it runs an animation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14009
The
onintrostartevent now fires after the delay period completes, rather than immediately when the transition is initiated. This ensures that the event accurately reflects when the intro animation actually starts.Changes
on_startcallback parameter toanimate()functionintrostartevent after delay animation finishes (inanimation.onfinish)Testing
This fix ensures that when a transition has a delay:
onintrostartevent fires after the delay completes