Skip to content

chore: Correct transport docs#13893

Merged
teemingc merged 2 commits into
mainfrom
elliott/13847
Jun 17, 2025
Merged

chore: Correct transport docs#13893
teemingc merged 2 commits into
mainfrom
elliott/13847

Conversation

@elliott-with-the-longest-name-on-github

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

Fixes #13847

The docs say you have to return false which is only partially correct; any falsey value will opt out of encoding

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented Jun 16, 2025 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f390aef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github marked this pull request as ready for review June 16, 2025 17:33
@svelte-docs-bot

svelte-docs-bot Bot commented Jun 16, 2025

Copy link
Copy Markdown

Preview: https://svelte-dev-git-preview-kit-13893-svelte.vercel.app/

Conduitry
Conduitry reviewed Jun 16, 2025
View reviewed changes
Comment thread documentation/docs/30-advanced/20-hooks.md Outdated
elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github commented Jun 16, 2025
View reviewed changes
Comment thread documentation/docs/30-advanced/20-hooks.md Outdated
@teemingc teemingc added the documentation Improvements or additions to documentation label Jun 17, 2025
@teemingc teemingc merged commit 293392b into main Jun 17, 2025
31 of 32 checks passed
@teemingc teemingc deleted the elliott/13847 branch June 17, 2025 04:37
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jun 21, 2025
@sidharthv96
Merge branch 'main' into sidv/styleText
f16e43d 
* main:
  bye bye red lines (sveltejs#13911)
  docs: mention support for vite 7 as well
  docs: mention that rolldown is experimental
  docs: expand changelog entry
  Version Packages (sveltejs#13908)
  feat: support Rolldown (sveltejs#13747)
  chore: Correct transport docs (sveltejs#13893)
Copilot AI pushed a commit to Stadly/kit that referenced this pull request Mar 6, 2026
@elliott-with-the-longest-name-on-github
chore: Correct transport docs (sveltejs#13893)
88410bc 
* chore: Correct transport docs

* Update documentation/docs/30-advanced/20-hooks.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Conduitry Conduitry Conduitry left review comments

@teemingc teemingc teemingc approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

transport hooks did not encode falsy value

3 participants

@elliott-with-the-longest-name-on-github @Conduitry @teemingc