Skip to content

feat: support Rolldown#13747

Merged
benmccann merged 46 commits into
mainfrom
rolldown
Jun 20, 2025
Merged

feat: support Rolldown#13747
benmccann merged 46 commits into
mainfrom
rolldown

Conversation

@teemingc

@teemingc teemingc commented Apr 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

closes #13738

This PR:

  • upgrades dev deps to usethe vite-plugin-svelte 6 pre-release
  • adds vite 7 and vite-plugin-svelte 6 to Kit's peer dep ranges
  • changes the enforced Vite config to support both https://github.com/vitejs/rolldown-vite and the current Vite release with Rollup.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented Apr 28, 2025 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c3d2e95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc linked an issue Apr 28, 2025 that may be closed by this pull request
Improved Vite rolldown support #13738
Closed
2 tasks
@teemingc teemingc added the vite label Apr 28, 2025
benmccann
benmccann reviewed Apr 28, 2025
View reviewed changes
Comment thread packages/kit/src/exports/vite/build/build_service_worker.js
@benmccann

benmccann commented Apr 30, 2025

Copy link
Copy Markdown
Member

I filed an issue for a follow-up here: #13756

@svelte-docs-bot

svelte-docs-bot Bot commented May 5, 2025

Copy link
Copy Markdown

Preview: https://svelte-dev-git-preview-kit-13747-svelte.vercel.app/

@benmccann benmccann mentioned this pull request May 5, 2025
Closed
6 tasks
@TorstenDittmann TorstenDittmann mentioned this pull request May 31, 2025
Closed
@sapphi-red

sapphi-red commented Jun 12, 2025

Copy link
Copy Markdown

preserveEntrySignatures is now supported with rolldown-vite@6.3.19. Let me know if there's any blockers on rolldown / rolldown-vite side.

sapphi-red
sapphi-red reviewed Jun 12, 2025
View reviewed changes
Comment thread packages/enhanced-img/src/vite-plugin.js Outdated
Comment thread packages/kit/src/exports/vite/index.js Outdated
@teemingc @sapphi-red
Update packages/kit/src/exports/vite/index.js
90bde1e 
Co-authored-by: 翠 <green@sapphi.red>
@teemingc teemingc removed this from the 3.0 milestone Jun 17, 2025
benmccann
benmccann reviewed Jun 17, 2025
View reviewed changes
Comment thread packages/kit/src/exports/vite/index.js
Comment thread packages/kit/test/apps/basics/test/client.test.js Outdated
@teemingc teemingc marked this pull request as ready for review June 19, 2025 03:51
benmccann
benmccann reviewed Jun 19, 2025
View reviewed changes
Comment thread pnpm-lock.yaml Outdated
benmccann
benmccann reviewed Jun 19, 2025
View reviewed changes
Comment thread .changeset/nine-ads-tease.md Outdated
benmccann
benmccann reviewed Jun 19, 2025
View reviewed changes
Comment thread .changeset/nine-ads-tease.md Outdated
@teemingc teemingc removed a link to an issue Jun 20, 2025
Improved Vite rolldown support #13738
Closed
2 tasks
@benmccann benmccann merged commit aaa4a31 into main Jun 20, 2025
18 checks passed
@benmccann benmccann deleted the rolldown branch June 20, 2025 03:02
@github-actions github-actions Bot mentioned this pull request Jun 20, 2025
Merged
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jun 21, 2025
@sidharthv96
Merge branch 'main' into sidv/styleText
f16e43d 
* main:
  bye bye red lines (sveltejs#13911)
  docs: mention support for vite 7 as well
  docs: mention that rolldown is experimental
  docs: expand changelog entry
  Version Packages (sveltejs#13908)
  feat: support Rolldown (sveltejs#13747)
  chore: Correct transport docs (sveltejs#13893)
Copilot AI pushed a commit to Stadly/kit that referenced this pull request Mar 6, 2026
@teemingc
feat: support Rolldown (sveltejs#13747)
9ebfd6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benmccann benmccann benmccann approved these changes

+2 more reviewers

@dominikg dominikg dominikg left review comments

@sapphi-red sapphi-red sapphi-red left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

vite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improved Vite rolldown support

4 participants

@teemingc @benmccann @sapphi-red @dominikg