Skip to content

Suppress invalid hook call warning for react 18#3564

Merged
kitten merged 1 commit intostyled-components:legacy-v5from
lynndylanhurley:suppress-react-18-invalid-hook-call
Aug 21, 2021
Merged

Suppress invalid hook call warning for react 18#3564
kitten merged 1 commit intostyled-components:legacy-v5from
lynndylanhurley:suppress-react-18-invalid-hook-call

Conversation

@lynndylanhurley
Copy link
Copy Markdown

This applies the same fix from #3521 to the legacy-v5 branch.

References #3521
References #3394
References #3409

@lynndylanhurley
Copy link
Copy Markdown
Author

@eps1lon @probablyup this applies the same fix from the v6 branch (main) to the legacy-v5 branch. The hope is that this is a small enough change that a patch release can be pushed to resolve the issue.

@lynndylanhurley lynndylanhurley force-pushed the suppress-react-18-invalid-hook-call branch from 2f38179 to 89d7576 Compare August 21, 2021 16:46
@kitten kitten merged commit 7e56e99 into styled-components:legacy-v5 Aug 21, 2021
@lynndylanhurley
Copy link
Copy Markdown
Author

Thanks @kitten! I'm happy to test this out if you can tag a new test release.

@kitten
Copy link
Copy Markdown
Member

kitten commented Aug 21, 2021

@lynndylanhurley Sure thing! I've created a new prerelease with the corresponding tag:

Package Version
styled-components@pr3564 5.3.1-pr3564

@lynndylanhurley
Copy link
Copy Markdown
Author

@kitten been using this for the past couple of days with the latest version of react 18. the issue has been resolved for me.

timiscoding added a commit to Back2Dev/attendance that referenced this pull request Aug 26, 2021
timiscoding added a commit to Back2Dev/attendance that referenced this pull request Nov 9, 2021
* tim-survey-builder: (26 commits)
  add readme
  Question types render own Inspector properties. Update parts atom to include type config.
  Enable importing absolute paths. Restructure folders.
  Recoil devtools. Mobile navbar views. Move items with animation.  Dnd lock axis.
  Improve mobile responsive for frame + single type. Refactor DND to avoid unneeded part rerenders.
  Short answer integration
  Start adding mobile responsiveness. Fix recoil not working in ios. Fix storybook startup issue due to new Framework imports.
  Fix ios bug where any component using react-tabulator eg. admin/forms/list won't show list items. see ngduc/react-tabulator#215
  Add ios build
  Add dragndrop for canvas
  Reinstalling storybook
  Load editor's json into builder. Builder can update editor source on clicking save. Update DND. Update placeholder type.
  Enable builder in editor without blowing up. Fix circular imports.
  Refactor recoil state. Load json and save source. Fix error in engine.js when using strict mode.
  Add toolbar to generate source. Refactor to make it easier to add new question types.
  Update single item styles
  Reduce storybook startup time. Update dnd for single items.
  Fix recoil + rbd bug github/facebookexperimental/Recoil#496 Fix styled-components bug github/styled-components/styled-components#3564
  Merge in Minh's short question code. Add dnd to single items.
  EditProperty can auto render with complex paths Modify single items in canvas and inspector
  ...
aplavsa pushed a commit to aplavsa/styled-components that referenced this pull request Mar 3, 2022
kibanamachine added a commit to elastic/kibana that referenced this pull request Sep 20, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[react@18] bump `styled-components`
(#192368)](#192368)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2024-09-20T09:26:47Z","message":"[react@18]
bump `styled-components` (#192368)\n\n## Summary\r\n\r\nPrep for
https://github.com/elastic/kibana/issues/138222\r\n\r\n\r\nThis PR
updates `styled-components` package to the latest v5 version. I\r\nwould
like to do it for react@18 upgrade to suppress a noisy warning\r\nthat
is coming from `styled-components` when it is used with
react@18.\r\nHere is that
PR\r\nhttps://github.com/styled-components/styled-components/pull/3564/files\r\n\r\n\r\nUpdates
the failed snapshot tests.\r\n\r\n\r\nDear reviewers, could you please
smoke-check your apps visually? This is\r\na minor upgrade, but I think
it is worth to click around
anyway.","sha":"b1434a446fecd1feae4230e0e9a4fbe0fea4d8f1","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","apm:review"],"title":"[react@18]
bump
`styled-components`","number":192368,"url":"https://github.com/elastic/kibana/pull/192368","mergeCommit":{"message":"[react@18]
bump `styled-components` (#192368)\n\n## Summary\r\n\r\nPrep for
https://github.com/elastic/kibana/issues/138222\r\n\r\n\r\nThis PR
updates `styled-components` package to the latest v5 version. I\r\nwould
like to do it for react@18 upgrade to suppress a noisy warning\r\nthat
is coming from `styled-components` when it is used with
react@18.\r\nHere is that
PR\r\nhttps://github.com/styled-components/styled-components/pull/3564/files\r\n\r\n\r\nUpdates
the failed snapshot tests.\r\n\r\n\r\nDear reviewers, could you please
smoke-check your apps visually? This is\r\na minor upgrade, but I think
it is worth to click around
anyway.","sha":"b1434a446fecd1feae4230e0e9a4fbe0fea4d8f1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192368","number":192368,"mergeCommit":{"message":"[react@18]
bump `styled-components` (#192368)\n\n## Summary\r\n\r\nPrep for
https://github.com/elastic/kibana/issues/138222\r\n\r\n\r\nThis PR
updates `styled-components` package to the latest v5 version. I\r\nwould
like to do it for react@18 upgrade to suppress a noisy warning\r\nthat
is coming from `styled-components` when it is used with
react@18.\r\nHere is that
PR\r\nhttps://github.com/styled-components/styled-components/pull/3564/files\r\n\r\n\r\nUpdates
the failed snapshot tests.\r\n\r\n\r\nDear reviewers, could you please
smoke-check your apps visually? This is\r\na minor upgrade, but I think
it is worth to click around
anyway.","sha":"b1434a446fecd1feae4230e0e9a4fbe0fea4d8f1"}}]}]
BACKPORT-->

---------

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants