Skip to content

[8.x] [react@18] bump `styled-components` (#192368)#193522

Merged
kibanamachine merged 3 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-192368
Sep 20, 2024
Merged

[8.x] [react@18] bump `styled-components` (#192368)#193522
kibanamachine merged 3 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-192368

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Prep for elastic#138222

This PR updates `styled-components` package to the latest v5 version. I
would like to do it for react@18 upgrade to suppress a noisy warning
that is coming from `styled-components` when it is used with react@18.
Here is that PR
https://github.com/styled-components/styled-components/pull/3564/files

Updates the failed snapshot tests.

Dear reviewers, could you please smoke-check your apps visually? This is
a minor upgrade, but I think it is worth to click around anyway.

(cherry picked from commit b1434a4)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Sep 20, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) September 20, 2024 09:31
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Sep 20, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@Dosant
Copy link
Copy Markdown
Contributor

Dosant commented Sep 20, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 20, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: bf1c5ad
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193522-bf1c5ad1a1d1

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #16 / When using CommandExecutionOutput component should show long running hint message if pending and >15s have passed

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +734.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Dosant

@kibanamachine kibanamachine merged commit 3ea6db6 into elastic:8.x Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants