Skip to content

Further st.experimental_connection polish omnibus PR #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vdonato merged 11 commits into from
Apr 21, 2023
Merged

Further st.experimental_connection polish omnibus PR #6530

vdonato merged 11 commits into from
Apr 21, 2023

Conversation

@vdonato
Copy link
Collaborator

@vdonato vdonato commented Apr 20, 2023

Note: This PR is dependent on #6529 for all tests to pass,
so we'll rebase the feature branch onto develop once #6529 is merged.

📚 Context

This is another PR fixing a bunch of miscellaneous things with st.experimental_connection that are
each too small to warrant having their own PRs. The changes are all pretty self-explanatory given their
corresponding commit messages so don't require much additional documentation here.

Also note that this PR should be far more easy to review commit-wise.

@vdonato vdonato added the security-assessment-completed Security assessment has been completed for PR label Apr 20, 2023
@vdonato vdonato requested a review from lukasmasuch April 20, 2023 22:49
sfc-gh-jcarroll
sfc-gh-jcarroll reviewed Apr 20, 2023
View reviewed changes
@vdonato vdonato force-pushed the feature/st.experimental_connection branch from 23900ac to 5cc7cd0 Compare April 20, 2023 23:55
@vdonato vdonato force-pushed the vdonato/misc-connection-tweaks-omnibus-2 branch 2 times, most recently from a758bbc to ae87cfd Compare April 21, 2023 00:03
@vdonato vdonato force-pushed the vdonato/misc-connection-tweaks-omnibus-2 branch from ae87cfd to 57cab53 Compare April 21, 2023 00:54
@vdonato vdonato force-pushed the vdonato/misc-connection-tweaks-omnibus-2 branch from 57cab53 to 085d33b Compare April 21, 2023 01:24
lukasmasuch
lukasmasuch approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vdonato vdonato force-pushed the vdonato/misc-connection-tweaks-omnibus-2 branch from 955faa5 to bda7e29 Compare April 21, 2023 06:40
@sfc-gh-jcarroll sfc-gh-jcarroll mentioned this pull request Apr 21, 2023
Merged
4 tasks
@vdonato vdonato merged commit e03141b into feature/st.experimental_connection Apr 21, 2023
@vdonato vdonato deleted the vdonato/misc-connection-tweaks-omnibus-2 branch April 21, 2023 20:09
@vdonato vdonato mentioned this pull request Apr 21, 2023
Merged
vdonato added a commit that referenced this pull request Apr 21, 2023
@vdonato
Further st.experimental_connection polish omnibus PR (#6530)
374ad7f 
* Remove "user" from required SnowparkConnection params

* Remove SnowparkConnection locking in __init__ method

* Remove handling for tenacity as an optional dependency

* Rename SQL -> SQLConnection

* Rename Snowpark -> SnowparkConnection

* Add nicer `st.experimental_connection` spinner message

* Support both session() and safe_session() in SnowparkConnection

* Make session a @Property

* Don't nest contextmanagers in SQLConnection

* Make SQLConnection.session a property

* Remove TODO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasmasuch lukasmasuch lukasmasuch approved these changes

+1 more reviewer

@sfc-gh-jcarroll sfc-gh-jcarroll sfc-gh-jcarroll left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vdonato @lukasmasuch @sfc-gh-jcarroll