Autoformat yaml in .github dir and enforce formatting #6497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3aadb72 to
29bc81e
Compare
29bc81e to
ec7ab29
Compare
mayagbarnes
reviewed
Apr 16, 2023
mayagbarnes
approved these changes
Apr 16, 2023
Collaborator
mayagbarnes
left a comment
There was a problem hiding this comment.
LGTM 👍🏼
Curious on the multi-line needs array in nightly, release & RC, but couldn't find an indication on whether this makes a difference. Easy fix if its somehow problematic.
Collaborator
Author
@mayagbarnes heads up that this comment made me realize it's a bit more idiomatic in markdown to use the hyphen list syntax in these situations rather than writing out the array explicitly: see 86c7db3 (the two are completely equivalent as far as I understand). I'll keep an eye on tonight's nightly run to verify that nothing weird happens due to this change |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 18, 2023
* develop: Create tag with constraints files for new releases (streamlit#6495) Autoformat yaml in .github dir and enforce formatting (streamlit#6497) Update metadata description (streamlit#6503) Update CODEOWNERS (streamlit#6496)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
When making some changes to some of our GitHub actions files, I noticed that the pre-save
autoformatter triggered by my editor was making changes. We might as well have
precommitdo this for us, so this change runs
prettieron everything in the.github/directory andenforces autoformatting going forward via
precommit.