Skip to content

Conversation

@vdonato
Copy link
Collaborator

@vdonato vdonato commented Apr 15, 2023

📚 Context

This PR makes a few small changes to our CODEOWNERS file:

  • Removed a stale comment
  • Reorganized entries a bit
  • Added explicit CODEOWNERS for both lib/streamlit/web/server/server.py and
    frontend/src/lib/DefaultStreamlitEndpoints.ts files.
    • We want to take extra care when modifying these for the same reason that we
      require specific codeowner approvals for protobuf changes: it's likely that changes
      to these files will have backwards compatibility implications for platforms that host
      Streamlit apps.

@vdonato vdonato added the security-assessment-completed Security assessment has been completed for PR label Apr 15, 2023
@vdonato vdonato merged commit e0ee2d7 into develop Apr 17, 2023
@vdonato vdonato deleted the vdonato/update-codeowners branch April 17, 2023 22:00
tconkling added a commit to tconkling/streamlit that referenced this pull request Apr 18, 2023
* develop:
  Create tag with constraints files for new releases (streamlit#6495)
  Autoformat yaml in .github dir and enforce formatting (streamlit#6497)
  Update metadata description (streamlit#6503)
  Update CODEOWNERS (streamlit#6496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants