Tweak some st.experimental_connection-related names #6437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
commented
Apr 5, 2023
Comment on lines
-14
to
-16
Collaborator
Author
There was a problem hiding this comment.
I'm not sure how this ended up being added here (this is the test module and not the actual connections code) -- must have just done so accidentally
kajarenc
approved these changes
Apr 6, 2023
a8cb2d3 to
317c82a
Compare
Base automatically changed from
vdonato/rework-api
to
feature/st.experimental_connection
April 6, 2023 21:55
b585d4d to
9fa93ea
Compare
317c82a to
6a54e39
Compare
vdonato
added a commit
that referenced
this pull request
Apr 6, 2023
* Prefix a bunch of our BaseConnection methods with an underscore * Add underscore in front of get_secrets * Rename _get_secrets() -> _secrets and make it a @Property * Tweak some st.experimental_connection-related names
vdonato
added a commit
that referenced
this pull request
Apr 10, 2023
* Prefix a bunch of our BaseConnection methods with an underscore * Add underscore in front of get_secrets * Rename _get_secrets() -> _secrets and make it a @Property * Tweak some st.experimental_connection-related names
vdonato
added a commit
that referenced
this pull request
Apr 11, 2023
* Prefix a bunch of our BaseConnection methods with an underscore * Add underscore in front of get_secrets * Rename _get_secrets() -> _secrets and make it a @Property * Tweak some st.experimental_connection-related names
vdonato
added a commit
that referenced
this pull request
Apr 15, 2023
* Prefix a bunch of our BaseConnection methods with an underscore * Add underscore in front of get_secrets * Rename _get_secrets() -> _secrets and make it a @Property * Tweak some st.experimental_connection-related names
vdonato
added a commit
that referenced
this pull request
Apr 17, 2023
* Prefix a bunch of our BaseConnection methods with an underscore * Add underscore in front of get_secrets * Rename _get_secrets() -> _secrets and make it a @Property * Tweak some st.experimental_connection-related names
vdonato
added a commit
that referenced
this pull request
Apr 19, 2023
* Prefix a bunch of our BaseConnection methods with an underscore * Add underscore in front of get_secrets * Rename _get_secrets() -> _secrets and make it a @Property * Tweak some st.experimental_connection-related names
vdonato
added a commit
that referenced
this pull request
Apr 20, 2023
* Prefix a bunch of our BaseConnection methods with an underscore * Add underscore in front of get_secrets * Rename _get_secrets() -> _secrets and make it a @Property * Tweak some st.experimental_connection-related names
vdonato
added a commit
that referenced
this pull request
Apr 21, 2023
* Prefix a bunch of our BaseConnection methods with an underscore * Add underscore in front of get_secrets * Rename _get_secrets() -> _secrets and make it a @Property * Tweak some st.experimental_connection-related names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is being targeted to the
vdonato/rework-apibranch for now to make the diff show up nicely.We'll be merging #6436 first, at which point we'll retarget this PR to
feature/st.experimental_connection.📚 Context
This is a small PR to tweak some names related to the upcoming
st.experimental_connectionfeature.We make the following changes:
get_secrets()->_secretsand made it a propertyBaseConnection->ExperimentalBaseConnection