Rework connection factory function API #6436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2023
kajarenc
reviewed
Apr 6, 2023
kajarenc
reviewed
Apr 6, 2023
Collaborator
|
LGTM 👍 |
kajarenc
approved these changes
Apr 6, 2023
vdonato
added a commit
that referenced
this pull request
Apr 6, 2023
* Remove the notion of default connection names * Rework connection factory API * Name type variable more descriptively * Change from Union[str, None] to Optional[str]
vdonato
added a commit
that referenced
this pull request
Apr 6, 2023
* Remove the notion of default connection names * Rework connection factory API * Name type variable more descriptively * Change from Union[str, None] to Optional[str]
vdonato
added a commit
that referenced
this pull request
Apr 10, 2023
* Remove the notion of default connection names * Rework connection factory API * Name type variable more descriptively * Change from Union[str, None] to Optional[str]
vdonato
added a commit
that referenced
this pull request
Apr 11, 2023
* Remove the notion of default connection names * Rework connection factory API * Name type variable more descriptively * Change from Union[str, None] to Optional[str]
vdonato
added a commit
that referenced
this pull request
Apr 15, 2023
* Remove the notion of default connection names * Rework connection factory API * Name type variable more descriptively * Change from Union[str, None] to Optional[str]
vdonato
added a commit
that referenced
this pull request
Apr 17, 2023
* Remove the notion of default connection names * Rework connection factory API * Name type variable more descriptively * Change from Union[str, None] to Optional[str]
vdonato
added a commit
that referenced
this pull request
Apr 19, 2023
* Remove the notion of default connection names * Rework connection factory API * Name type variable more descriptively * Change from Union[str, None] to Optional[str]
vdonato
added a commit
that referenced
this pull request
Apr 20, 2023
* Remove the notion of default connection names * Rework connection factory API * Name type variable more descriptively * Change from Union[str, None] to Optional[str]
vdonato
added a commit
that referenced
this pull request
Apr 21, 2023
* Remove the notion of default connection names * Rework connection factory API * Name type variable more descriptively * Change from Union[str, None] to Optional[str]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This PR reworks the API of the
st.experimental_connectionfactory function. After some discussion, wedecided that it'd be better to flip the arguments so that the name of a connection comes before its type.
We also (although this is still being finalized) decided to allow users to specify the types of their connections
either via the corresponding section in the
secrets.tomlfile or viakwargto the factory function.Note:
kwarg.should be quite straightforward, so it's worth reviewing this PR now and potentially making changes
down the line.