Cypress Upgrade to 9.7.0 #6322
Cypress Upgrade to 9.7.0 #6322
Conversation
There was a problem hiding this comment.
Cypress has removed the moment.js lib and recommends using dayjs instead
There was a problem hiding this comment.
Resulting snapshot change as part of adding .wait
There was a problem hiding this comment.
Adding the .wait is necessary to make sure the background of the map completely loads.
Without using wait to ensure background load, this test is flaky - sometimes the background will load before the snap is taken for comparison and sometimes it won't - causing failure.
There was a problem hiding this comment.
Can you verify this manually? The iframe e2e test focuses on expanding to avoid scrolling necessarily. The screenshots being larger give me pause (but unlikely is a problem)
frontend/cypress/snapshots/linux/2x/st_map.spec.js/stDeckGlJsonChart.snap.png
Show resolved
Hide resolved
There was a problem hiding this comment.
This is the most interesting one to me on what's going on...I imagine it's viewport stuff.
* develop: (48 commits) ForwardMessageCache: interface-ize endpoint (streamlit#6326) Add an event handler for popstate event to reflect user's back button being clicked (streamlit#6271) Cypress Upgrade to 9.7.0 (streamlit#6322) Remove default values from internal class reprs FileUploadClient: interface-ize endpoint (streamlit#6323) Fix issue streamlit#6310 (streamlit#6321) Make using @ts-ignore illegal (streamlit#6314) Add nightly-preview deploy to nightly build (streamlit#6306) Minor documentation fixes for cache storage (streamlit#6222) Add react-dropzone prop to address disabled file type behavior (streamlit#6315) Add timeout to label-markdown spec (streamlit#6312) ascii diagrams for CacheStorage* protocols, and for LocalDiskCacheStorage* concrete implementation (streamlit#6220) Bump @sideway/formula from 3.0.0 to 3.0.1 in /frontend (streamlit#6309) Bump webpack from 5.75.0 to 5.76.0 in /frontend (streamlit#6313) Replace @ts-ignore with @ts-expect-error and remove unused directives (streamlit#6308) Up version to 1.20.0 (streamlit#6284) Pull ComponentRegistry's URL generation into an interface (streamlit#6307) Add st.divider (streamlit#6178) fix: upgrade multiple dependencies with Snyk (streamlit#6262) Activate the no-unused-vars rule in eslint. (streamlit#6300) ...
📚 Context
Upgrading our Cypress version from
v6.9.1tov9.7.0. This significantly improves our Cypress test flakiness: 3 of the last 10 Cypress test runs ondevelopfailed as a result of hitting the Cypress verification timing out.🧠 Description of Changes
CYPRESS_VERIFY_TIMEOUTenv variable to reduce occurrences of failed verification🧪 Testing Done