Activate the no-unused-vars rule in eslint. #6300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tszerszen
approved these changes
Mar 13, 2023
Contributor
sfc-gh-tszerszen
left a comment
There was a problem hiding this comment.
LGTM 👍 I did not expect so much unused vars, thanks Michał! 🥇
vdonato
approved these changes
Mar 13, 2023
# Conflicts: # frontend/src/hocs/withHostCommunication/withHostCommunication.test.tsx
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Mar 17, 2023
* develop: (48 commits) ForwardMessageCache: interface-ize endpoint (streamlit#6326) Add an event handler for popstate event to reflect user's back button being clicked (streamlit#6271) Cypress Upgrade to 9.7.0 (streamlit#6322) Remove default values from internal class reprs FileUploadClient: interface-ize endpoint (streamlit#6323) Fix issue streamlit#6310 (streamlit#6321) Make using @ts-ignore illegal (streamlit#6314) Add nightly-preview deploy to nightly build (streamlit#6306) Minor documentation fixes for cache storage (streamlit#6222) Add react-dropzone prop to address disabled file type behavior (streamlit#6315) Add timeout to label-markdown spec (streamlit#6312) ascii diagrams for CacheStorage* protocols, and for LocalDiskCacheStorage* concrete implementation (streamlit#6220) Bump @sideway/formula from 3.0.0 to 3.0.1 in /frontend (streamlit#6309) Bump webpack from 5.75.0 to 5.76.0 in /frontend (streamlit#6313) Replace @ts-ignore with @ts-expect-error and remove unused directives (streamlit#6308) Up version to 1.20.0 (streamlit#6284) Pull ComponentRegistry's URL generation into an interface (streamlit#6307) Add st.divider (streamlit#6178) fix: upgrade multiple dependencies with Snyk (streamlit#6262) Activate the no-unused-vars rule in eslint. (streamlit#6300) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This change enables checking for unused variables in the Streamlit codebase. Checking for unused variables is useful when refactoring - for example, when splitting a function into two, we can make sure that all parameters have been moved correctly. As we already have some unused vars in our code, this PR removes them to ensure that the linter passes the checks introduced.
What kind of change does this PR introduce?
🧠 Description of Changes
Add bullet points summarizing your changes here
Revised:
Insert screenshot of your updated UI/code here
Current:
Insert screenshot of existing UI/code here
🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.