Docs: move note to experimental_allow_widgets param description
#5843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thanks @sfc-gh-tszerszen! Could you help me merge this PR too? Along with #5831. I don't have merge permissions. |
tconkling
added a commit
that referenced
this pull request
Dec 20, 2022
* develop: Change workers balancing logic for e2e tests to always cover all specs (#5865) Up version to 1.16.0 (#5852) Stop installing pip-tools (#5854) Add eslint no relative import paths plugin to pre commit hooks (#5839) Docs: move note to `experimental_allow_widgets` param description (#5843) Update element docstrings for colored text support (#5831) Add remark-directive plugin (Support for colored text in markdown) (#5774) Teach WebsocketConnection how to wait on an external auth token (#5728) Turn on streamlit theme for altair and plotly (#5796) Fix markdown headers spacing (#5829) Update error message and docstring in st.map (#5792) Remove unnecessarily methods from DeltaGenerator (#5824) Resolve vega-tooltip to later version (#5825) Easter Egg (#5817) Update Exception Layout to avoid overflow (#5700)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
The docstrings for memo and singleton include a note about the experimental nature of the
experimental_allow_widgetsparameter and how using it may lead to excessive memory usage. This PR moves the note into the parameter description ofexperimental_allow_widgets.What kind of change does this PR introduce?
🧠 Description of Changes
This PR moves the note about the
experimental_allow_widgetsparam from memo and singleton docstrings into the parameter description ofexperimental_allow_widgets.Note: this PR neither adds nor update any tests as the changes are merely a refactor of docstrings.
Revised:
Current:
🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.