Skip to content

Conversation

@mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Dec 5, 2022

New Years Easter Egg - see Notion doc

📚 Context

Running Man modification for New Years

  • What kind of change does this PR introduce?
    • Feature

🧠 Description of Changes

  • Added new gif
  • Added function to test the current date based on client local date/time, change gif rendered accordingly
    • This is a visible (user-facing) change

🧪 Testing Done

  • Manual Testing
  • Add FE Unit Tests
  • QA Testing - doc link

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@mayagbarnes mayagbarnes added the security-assessment-completed Security assessment has been completed for PR label Dec 5, 2022
@mayagbarnes mayagbarnes marked this pull request as ready for review December 7, 2022 07:47
@mayagbarnes mayagbarnes merged commit 92f64cc into develop Dec 7, 2022
@mayagbarnes mayagbarnes deleted the feature/easter-egg branch December 7, 2022 20:26
tconkling added a commit that referenced this pull request Dec 20, 2022
* develop:
  Change workers balancing logic for e2e tests to always cover all specs (#5865)
  Up version to 1.16.0 (#5852)
  Stop installing pip-tools (#5854)
  Add eslint no relative import paths plugin to pre commit hooks (#5839)
  Docs: move note to `experimental_allow_widgets` param description (#5843)
  Update element docstrings for colored text support (#5831)
  Add remark-directive plugin (Support for colored text in markdown) (#5774)
  Teach WebsocketConnection how to wait on an external auth token (#5728)
  Turn on streamlit theme for altair and plotly (#5796)
  Fix markdown headers spacing (#5829)
  Update error message and docstring in st.map (#5792)
  Remove unnecessarily methods from DeltaGenerator (#5824)
  Resolve vega-tooltip to later version (#5825)
  Easter Egg (#5817)
  Update Exception Layout to avoid overflow (#5700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants