Skip to content

Fix multipage apps e2e test describe block #5810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vdonato merged 1 commit into from
Dec 6, 2022
Merged

Fix multipage apps e2e test describe block #5810

vdonato merged 1 commit into from
Dec 6, 2022

Conversation

@vdonato
Copy link
Collaborator

@vdonato vdonato commented Dec 4, 2022

I noticed the top-level describe for the multipage e2e tests is labeled as st.map, probably
because I copy-pasted the describe block and forgot to change the title, then it managed to
slip by in code review.

@vdonato vdonato added the security-assessment-completed Security assessment has been completed for PR label Dec 4, 2022
@vdonato vdonato merged commit f777633 into streamlit:develop Dec 6, 2022
@vdonato vdonato deleted the fix-mpa-test-describe branch December 6, 2022 00:07
tconkling added a commit that referenced this pull request Dec 6, 2022
@tconkling
Merge branch 'develop' into feature/ReleaseCacheV2
28ac434 
* develop:
  Fix multipage apps e2e test describe block (#5810)
  Replace closeConnection with shutdownRuntime and disconnectWebsocket (#5809)
  Fix infrequently occurring (≤ 10) pydocstyle error codes (#5777)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tconkling tconkling tconkling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vdonato @tconkling