Skip to content

Replace closeConnection with shutdownRuntime and disconnectWebsocket #5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vdonato merged 1 commit into from
Dec 5, 2022
Merged

Replace closeConnection with shutdownRuntime and disconnectWebsocket #5809

vdonato merged 1 commit into from
Dec 5, 2022

Conversation

@vdonato
Copy link
Collaborator

@vdonato vdonato commented Dec 4, 2022 •
edited
Loading

📚 Context

This is another change that's being made because we need it for the feature/session-manager branch
but is being made straight to develop to keep the final diff size down.

The special test-only closeConnection proto message type has a pretty misleading name because what
it really does is shut down the runtime entirely. Because we need a way to test reconnect behavior (and thus
a way to close only the browser websocket connection without nuking the entire Streamlit server), we replace
this proto type with debugShutdownRuntime and debugDisconnectWebsocket, which do what their names
suggest.

🧪 Testing Done

  • Added/Updated e2e tests

@vdonato vdonato added the security-assessment-completed Security assessment has been completed for PR label Dec 4, 2022
@vdonato vdonato force-pushed the better_debug_commands branch from cd2e921 to bd13547 Compare December 4, 2022 05:38
tconkling
tconkling approved these changes Dec 5, 2022
View reviewed changes
@vdonato vdonato force-pushed the better_debug_commands branch from bd13547 to ed5ea50 Compare December 5, 2022 23:27
@vdonato vdonato merged commit bd167a5 into streamlit:develop Dec 5, 2022
@vdonato vdonato deleted the better_debug_commands branch December 5, 2022 23:53
tconkling added a commit that referenced this pull request Dec 6, 2022
@tconkling
Merge branch 'develop' into feature/ReleaseCacheV2
28ac434 
* develop:
  Fix multipage apps e2e test describe block (#5810)
  Replace closeConnection with shutdownRuntime and disconnectWebsocket (#5809)
  Fix infrequently occurring (≤ 10) pydocstyle error codes (#5777)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasmasuch lukasmasuch Awaiting requested review from lukasmasuch

1 more reviewer

@tconkling tconkling tconkling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vdonato @tconkling