memo_test/singleton_test: ensure ScriptRunCtx exists #5739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new widget replay functionality relies on ScriptRunContext; running these tests in isolation (outside of the full test suite) currently results in test failures due to a missing context. (When run as part of the full test suite, some other ScriptRunContext-creating test will run first, which is why they don't fail in that circumstance.)
kajarenc
reviewed
Nov 21, 2022
| class MemoTest(unittest.TestCase): | ||
| def setUp(self) -> None: | ||
| # Caching functions rely on an active script run ctx | ||
| add_script_run_ctx(threading.current_thread(), create_mock_script_run_ctx()) |
Collaborator
There was a problem hiding this comment.
Should we call super().setUp() since we call super().tearDown() in tear down?
kajarenc
approved these changes
Nov 21, 2022
Collaborator
|
LGTM 👍 Snowflake credentials test CI check is not blocking, we are good to merge PR! |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 21, 2022
# By Abhik Lodh (1) and others # Via GitHub * develop: memo_test/singleton_test: ensure ScriptRunCtx exists (streamlit#5739) Update loadApp command timeout (streamlit#5731) Allow emojis with variant selectors to be validated (streamlit#5583) # Conflicts: # lib/tests/streamlit/runtime/caching/cache_data_api_test.py # lib/tests/streamlit/runtime/caching/cache_resource_api_test.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our new cache function "widget replay" functionality relies on a
ScriptRunContextexisting: without aScriptRunContext, no values will be written to the cached function.Some of our caching tests don't create a
ScriptRunContext. Running these tests in isolation (outside of the full test suite) currently results in test failures due to a missing context. (When run as part of the full test suite, some other ScriptRunContext-creating test will run first, which is why they don't fail in that circumstance.)