Update loadApp command timeout #5731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
approved these changes
Nov 18, 2022
Collaborator
vdonato
left a comment
There was a problem hiding this comment.
LGTM
We could alternatively increase the timeout to 20s everywhere since it shouldn't slow down tests that take less time, but I don't have a strong opinion either way
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 21, 2022
# By Abhik Lodh (1) and others # Via GitHub * develop: memo_test/singleton_test: ensure ScriptRunCtx exists (streamlit#5739) Update loadApp command timeout (streamlit#5731) Allow emojis with variant selectors to be validated (streamlit#5583) # Conflicts: # lib/tests/streamlit/runtime/caching/cache_data_api_test.py # lib/tests/streamlit/runtime/caching/cache_resource_api_test.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
I've noticed 3 specs fail on the 'before all' hook lately - See Flaky Tests section of Notion doc for addtl. details
Based on the videos, they are failing in
loadApp, which checks that the script is no longer running via the StatusWidget with a 10000 millisecond timeout. This doesn't seem to be enough time for some of the scripts in the CI runner, so I added a longer timeout to allow the script to finish running.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.