Skip to content

Conversation

@tconkling
Copy link
Contributor

@tconkling tconkling commented Oct 22, 2019

Turns off the "@typescript-eslint/ban-ts-ignore rule, which we need in a few places for JS libs that lack type definitions.

There are valid reasons for occasionally using it
@tconkling tconkling requested a review from a team October 22, 2019 16:12
* develop:
  Update Pipfile (streamlit#505)
  Release 0.49.0 (streamlit#509)
  Removing package json (streamlit#501)
  Feature/input number (streamlit#416)
@tconkling tconkling merged commit 6a693a1 into streamlit:develop Oct 23, 2019
@tconkling tconkling deleted the tim/AllowTSIgnore branch October 23, 2019 22:48
tconkling added a commit to tconkling/streamlit that referenced this pull request Oct 29, 2019
* develop:
  Use custom context manager for temporary file in cli.py (streamlit#489)
  Update pull_request_template.md
  Update pull_request_template.md
  Handle lack of trailing slash (streamlit#528)
  Set auto_envvar_prefix to STREAMLIT (streamlit#477)
  Strip slashes in path components (streamlit#523)
  Create doc_improvement.md
  ESlint: allow @ts-ignore (streamlit#499)
  Update Pipfile (streamlit#505)
  Release 0.49.0 (streamlit#509)
  Removing package json (streamlit#501)
  Feature/input number (streamlit#416)
  ESLint warnings are fatal in Circle (streamlit#492)
  Doc updates (streamlit#286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants