Doc updates #286
Merged
Doc updates #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tarted that lets the reader know then can pass both files and URLs to streamlit run as arguments.
Contributor
Author
|
@kellyamanda - Let me know if this tip bubble approach for passing URLs with streamlit run works for you. I also updated the prereq that you requested via email. |
tvst
approved these changes
Oct 8, 2019
tvst
reviewed
Oct 8, 2019
dnuske
reviewed
Oct 11, 2019
docs/index.md
Outdated
| 1. Before you do anything else, make sure that you have [Python 2.7.0 or later | ||
| / Python 3.6.x or later](https://www.python.org/downloads/). | ||
| 1. Make sure that you have [Python 2.7.0 | ||
| / Python 3.6.x or later](https://www.python.org/downloads/) installed. |
Contributor
There was a problem hiding this comment.
We should not remove the "or later" next to Python 2.7.0, as alternative it could say "Make sure that you have Python 2.7.x / 3.6.x installed."
Contributor
Author
There was a problem hiding this comment.
Does that capture the fact that folks can use 3.7/3.8? just making sure we aren't making the readers think they're limited to 3.6.x. I'll change it for now, but something we should think about. What do you think @tvst?
Contributor
There was a problem hiding this comment.
Just keep it with the 'or later':
Make sure that you have [Python 2.7.x / Python 3.6.x or later]
tvst
approved these changes
Oct 22, 2019
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Oct 29, 2019
* develop: Use custom context manager for temporary file in cli.py (streamlit#489) Update pull_request_template.md Update pull_request_template.md Handle lack of trailing slash (streamlit#528) Set auto_envvar_prefix to STREAMLIT (streamlit#477) Strip slashes in path components (streamlit#523) Create doc_improvement.md ESlint: allow @ts-ignore (streamlit#499) Update Pipfile (streamlit#505) Release 0.49.0 (streamlit#509) Removing package json (streamlit#501) Feature/input number (streamlit#416) ESLint warnings are fatal in Circle (streamlit#492) Doc updates (streamlit#286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting LP prereq to one line. Adding note to main concepts and get tarted that lets the reader know then can pass both files and URLs to streamlit run as arguments.
Contribution License Agreement
By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.