[feat] Update AGENTS rules for better a11y practices #13411
Merged
+69
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ PR preview is ready!
|
This was referenced Dec 18, 2025
Collaborator
Author
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This was referenced Dec 18, 2025
sfc-gh-bnisco
commented
Dec 18, 2025
| ## Static Data Structures | ||
|
|
||
| - Extract static lookup maps and constants to module-level scope outside functions/components | ||
| - Static data recreated on every call/render wastes memory and CPU | ||
| - Exception: Keep inside function only if data depends on parameters, props, or state | ||
|
|
||
| <good-example> | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
note: These newlines are to fix prettier. Without them, it doesn't properly detect the code blocks delineated by ```
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive accessibility (a11y) guidelines to the TypeScript coding standards across three configuration files used by AI coding agents and developers. The guidelines establish best practices for creating accessible web interfaces in the Streamlit frontend codebase.
Key changes:
- Added a new "Accessibility (a11y) principles" section with 5 major guidelines covering semantic HTML, accessible naming, assistive technology support, keyboard interaction, and focus styling
- Minor formatting improvements to existing code examples in the "Static Data Structures" section
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
frontend/AGENTS.md |
Added accessibility guidelines section and improved code example formatting |
.github/instructions/typescript.instructions.md |
Added identical accessibility guidelines section and improved code example formatting |
.cursor/rules/typescript.mdc |
Added identical accessibility guidelines section and improved code example formatting |
74c62a2 to
8b8a1f9
Compare
Contributor
📈 Frontend coverage change detectedThe frontend unit test (vitest) coverage has increased by 0.0300%
🎉 Great job on improving test coverage! |
Collaborator
Author
|
Thank you for the approval, @lukasmasuch , can you also approve with your sfc-gh account? Thank you! |
sfc-gh-lmasuch
approved these changes
Dec 22, 2025
Collaborator
Author
Merge activity
|
8b8a1f9 to
f11bd0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added comprehensive accessibility (a11y) guidelines to TypeScript coding standards.
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.