[fix] Ensure help Tooltips are accessible #13379

sfc-gh-bnisco · 2025-12-16T04:38:49Z

Describe your changes

Improved accessibility of help tooltips across Streamlit components:

Made help tooltips keyboard accessible:
- Help icons are now proper buttons with appropriate ARIA labels
- Tooltips can be opened via keyboard focus
- Tooltips can be dismissed with Escape key without losing focus
- Added tests to verify keyboard accessibility
Refactored widget help icon implementation:
- Created dedicated WidgetLabelHelpIcon and WidgetLabelHelpIconInline components
- Ensured consistent accessible names for help buttons (e.g., "Help for Label")
- Fixed nested label issues in widget labels with help icons
- Updated all widget components to use the new help icon components
Fixed test selectors:
- Updated selectors in e2e tests
- Added explicit focus testing in directory upload button test

Screenshot or video (only for visual changes)

In this video, I navigate to the Tooltip via keyboard, it displays. I tab away and it is hidden. When I tab back, it displays, I click escape and the Tooltip itself is hidden but the trigger focus state remains:

Kapture.2025-12-16.at.16.08.26.mp4

In this video, I use the keyboard to bring focus to the Help on a Streamlit component (in this case, a Slider), to show how keyboarding works here too:

Kapture.2025-12-16.at.16.09.24.mp4

GitHub Issue Link (if applicable)

Fixes Make help tooltips keyboard accessible #13330

Testing Plan

✅ Adds e2e tests
✅ Adds unit tests

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

snyk-io · 2025-12-16T04:38:57Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

github-actions · 2025-12-16T04:39:04Z

✅ PR preview is ready!

Name	Link
📦 Wheel file	https://core-previews.s3-us-west-2.amazonaws.com/pr-13379/streamlit-1.52.2-py3-none-any.whl
📦 `@streamlit/component-v2-lib`	Download from artifacts
🕹️ Preview app	pr-13379.streamlit.app (☁️ Deploy here if not accessible)

sfc-gh-bnisco · 2025-12-16T04:39:05Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

frontend/lib/src/components/shared/TooltipIcon/TooltipIcon.test.tsx

Copilot

Pull request overview

This PR enhances accessibility for help tooltips across Streamlit widgets by making them keyboard-navigable and properly labeled for screen readers. The changes fix issue #13330 by introducing focusable button triggers with appropriate ARIA labels for all help tooltips.

Key Changes

Introduced WidgetLabelHelpIcon and WidgetLabelHelpIconInline wrapper components that ensure help tooltips have accessible names
Refactored TooltipIcon to render a focusable <button> with required ariaLabel when no custom trigger is provided
Updated WidgetLabel to wrap label text in aria-hidden="true" span, preventing duplicate announcements while keeping help icons accessible
Standardized focus ring styling by introducing getFocusRingBoxShadow utility (applied in Checkbox)

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`TooltipIcon.tsx`	Core accessibility improvements: renders focusable button trigger with required aria-label, adds `getHelpTooltipAriaLabel` utility
`TooltipIcon.test.tsx`	Comprehensive test coverage for keyboard navigation, focus management, and aria-label generation
`WidgetLabelHelpIcon.tsx`	New wrapper component for standard widget help tooltips with automatic aria-label generation
`WidgetLabelHelpIconInline.tsx`	New wrapper component for inline help tooltips (checkboxes, radio buttons, etc.)
`WidgetLabel.tsx`	Wraps label text in aria-hidden span to prevent duplicate screen reader announcements
`WidgetLabel.test.tsx`	Tests verifying help icons remain accessible and no nested labels are rendered
`BaseWidget/styled-components.ts`	Added deprecation notices for `StyledWidgetLabelHelp` and `StyledWidgetLabelHelpInline`
`BaseWidget/index.ts`	Exports new wrapper components
`TooltipIcon/styled-components.ts`	Added `StyledTooltipTriggerButton` with focus-visible styles, refined icon selector
Widget components (TimeInput, TextInput, TextArea, Slider, NumberInput, Multiselect, FileUploader, DateTimeInput, DateInput, CameraInput, AudioInput)	Replaced direct `TooltipIcon` usage with `WidgetLabelHelpIcon`, passing label prop for accessible naming
Inline widgets (Checkbox, ButtonGroup, Radio, BaseColorPicker, Metric)	Replaced direct `TooltipIcon` usage with `WidgetLabelHelpIconInline`, passing label prop
`Checkbox.tsx`	Refactored to use `getFocusRingBoxShadow` utility for consistent focus styling
`ChatFileUploadButton.tsx`	Added comment and explicit `role="presentation"` to react-dropzone wrapper to prevent duplicate tab stops
`st_slider_test.py`	Added keyboard accessibility test using `tab_until_focused` helper
`st_number_input_test.py`	Added `exact=True` to `get_by_label` to avoid matching help button
`st_chat_input_test.py`	Updated to use semantic role-based query instead of test-id
`help_tooltip_test.py`	Updated to use more specific test-id selector

github-actions · 2025-12-16T04:49:03Z

📈 Frontend coverage change detected

The frontend unit test (vitest) coverage has increased by 0.0300%

Current PR: 86.4200% (12694 lines, 1723 missed)
Latest develop: 86.3900% (12662 lines, 1723 missed)

🎉 Great job on improving test coverage!

📊 View detailed coverage comparison

Copilot

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 4 comments.

frontend/lib/src/components/shared/TooltipIcon/TooltipIcon.tsx

frontend/lib/src/components/widgets/ChatInput/fileUpload/ChatFileUploadButton.tsx

e2e_playwright/st_chat_input_test.py

Copilot

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 4 comments.

frontend/lib/src/components/widgets/BaseWidget/WidgetLabelHelpIcon.tsx

frontend/lib/src/components/widgets/BaseWidget/WidgetLabelHelpIconInline.tsx

frontend/lib/src/components/shared/TooltipIcon/TooltipIcon.tsx

frontend/lib/src/components/widgets/BaseWidget/styled-components.ts

Copilot

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.

frontend/lib/src/components/shared/TooltipIcon/TooltipIcon.test.tsx

github-actions · 2025-12-16T23:27:52Z

📈 Python coverage change detected

The Python unit test coverage has increased by 0.0048%

Current PR: 92.7462% (20996 statements, 1523 missed)
Latest develop: 92.7415% (20996 statements, 1524 missed)

✅ Coverage change is within normal range.

Coverage by files

Name	Stmts	Miss	Cover
streamlit/__init__.py	142	0	100%
streamlit/__main__.py	3	3	0%
streamlit/auth_util.py	100	25	75%
streamlit/cli_util.py	39	6	85%
streamlit/column_config.py	3	0	100%
streamlit/commands/__init__.py	0	0	100%
streamlit/commands/echo.py	54	11	80%
streamlit/commands/execution_control.py	70	10	86%
streamlit/commands/experimental_query_params.py	40	2	95%
streamlit/commands/logo.py	41	6	85%
streamlit/commands/navigation.py	106	2	98%
streamlit/commands/page_config.py	106	4	96%
streamlit/components/__init__.py	0	0	100%
streamlit/components/lib/__init__.py	0	0	100%
streamlit/components/lib/local_component_registry.py	35	2	94%
streamlit/components/types/__init__.py	0	0	100%
streamlit/components/types/base_component_registry.py	14	0	100%
streamlit/components/types/base_custom_component.py	49	6	88%
streamlit/components/v1/__init__.py	5	0	100%
streamlit/components/v1/component_arrow.py	33	8	76%
streamlit/components/v1/component_registry.py	41	3	93%
streamlit/components/v1/components.py	4	4	0%
streamlit/components/v1/custom_component.py	85	7	92%
streamlit/components/v2/__init__.py	24	0	100%
streamlit/components/v2/bidi_component/__init__.py	4	0	100%
streamlit/components/v2/bidi_component/constants.py	5	0	100%
streamlit/components/v2/bidi_component/main.py	152	17	89%
streamlit/components/v2/bidi_component/serialization.py	81	2	98%
streamlit/components/v2/bidi_component/state.py	13	0	100%
streamlit/components/v2/component_definition_resolver.py	30	0	100%
streamlit/components/v2/component_file_watcher.py	117	9	92%
streamlit/components/v2/component_manager.py	97	13	87%
streamlit/components/v2/component_manifest_handler.py	24	0	100%
streamlit/components/v2/component_path_utils.py	68	5	93%
streamlit/components/v2/component_registry.py	121	8	93%
streamlit/components/v2/get_bidi_component_manager.py	8	1	88%
streamlit/components/v2/manifest_scanner.py	224	25	89%
streamlit/components/v2/presentation.py	84	19	77%
streamlit/components/v2/types.py	8	8	0%
streamlit/config.py	412	12	97%
streamlit/config_option.py	79	3	96%
streamlit/config_util.py	288	7	98%
streamlit/connections/__init__.py	6	0	100%
streamlit/connections/base_connection.py	45	0	100%
streamlit/connections/snowflake_connection.py	60	13	78%
streamlit/connections/snowpark_connection.py	44	3	93%
streamlit/connections/sql_connection.py	56	6	89%
streamlit/connections/util.py	33	0	100%
streamlit/cursor.py	130	1	99%
streamlit/dataframe_util.py	506	51	90%
streamlit/delta_generator.py	250	7	97%
streamlit/delta_generator_singletons.py	74	7	91%
streamlit/deprecation_util.py	59	4	93%
streamlit/development.py	1	0	100%
streamlit/elements/__init__.py	0	0	100%
streamlit/elements/alert.py	60	0	100%
streamlit/elements/arrow.py	201	15	93%
streamlit/elements/balloons.py	10	0	100%
streamlit/elements/bokeh_chart.py	9	0	100%
streamlit/elements/code.py	20	1	95%
streamlit/elements/deck_gl_json_chart.py	104	10	90%
streamlit/elements/dialog_decorator.py	38	0	100%
streamlit/elements/doc_string.py	227	9	96%
streamlit/elements/empty.py	16	4	75%
streamlit/elements/exception.py	101	10	90%
streamlit/elements/form.py	56	2	96%
streamlit/elements/graphviz_chart.py	36	1	97%
streamlit/elements/heading.py	56	0	100%
streamlit/elements/html.py	49	0	100%
streamlit/elements/iframe.py	29	0	100%
streamlit/elements/image.py	32	0	100%
streamlit/elements/json.py	44	6	86%
streamlit/elements/layouts.py	140	3	98%
streamlit/elements/lib/__init__.py	0	0	100%
streamlit/elements/lib/built_in_chart_utils.py	391	26	93%
streamlit/elements/lib/color_util.py	100	4	96%
streamlit/elements/lib/column_config_utils.py	169	1	99%
streamlit/elements/lib/column_types.py	189	4	98%
streamlit/elements/lib/dialog.py	69	1	99%
streamlit/elements/lib/dicttools.py	39	2	95%
streamlit/elements/lib/file_uploader_utils.py	30	0	100%
streamlit/elements/lib/form_utils.py	26	0	100%
streamlit/elements/lib/image_utils.py	176	21	88%
streamlit/elements/lib/js_number.py	28	3	89%
streamlit/elements/lib/layout_utils.py	121	1	99%
streamlit/elements/lib/mutable_status_container.py	73	4	95%
streamlit/elements/lib/options_selector_utils.py	90	0	100%
streamlit/elements/lib/pandas_styler_utils.py	80	2	98%
streamlit/elements/lib/policies.py	56	1	98%
streamlit/elements/lib/shortcut_utils.py	42	2	95%
streamlit/elements/lib/streamlit_plotly_theme.py	49	0	100%
streamlit/elements/lib/subtitle_utils.py	76	13	83%
streamlit/elements/lib/utils.py	76	5	93%
streamlit/elements/map.py	110	1	99%
streamlit/elements/markdown.py	65	2	97%
streamlit/elements/media.py	181	8	96%
streamlit/elements/metric.py	104	0	100%
streamlit/elements/pdf.py	49	2	96%
streamlit/elements/plotly_chart.py	129	6	95%
streamlit/elements/progress.py	36	0	100%
streamlit/elements/pyplot.py	39	2	95%
streamlit/elements/snow.py	10	0	100%
streamlit/elements/space.py	12	0	100%
streamlit/elements/spinner.py	44	3	93%
streamlit/elements/text.py	16	0	100%
streamlit/elements/toast.py	26	0	100%
streamlit/elements/vega_charts.py	228	3	99%
streamlit/elements/widgets/__init__.py	0	0	100%
streamlit/elements/widgets/audio_input.py	68	10	85%
streamlit/elements/widgets/button.py	245	6	98%
streamlit/elements/widgets/button_group.py	171	1	99%
streamlit/elements/widgets/camera_input.py	62	10	84%
streamlit/elements/widgets/chat.py	237	58	76%
streamlit/elements/widgets/checkbox.py	52	0	100%
streamlit/elements/widgets/color_picker.py	59	2	97%
streamlit/elements/widgets/data_editor.py	254	14	94%
streamlit/elements/widgets/file_uploader.py	108	18	83%
streamlit/elements/widgets/multiselect.py	105	4	96%
streamlit/elements/widgets/number_input.py	143	5	97%
streamlit/elements/widgets/radio.py	83	5	94%
streamlit/elements/widgets/select_slider.py	97	0	100%
streamlit/elements/widgets/selectbox.py	103	2	98%
streamlit/elements/widgets/slider.py	241	8	97%
streamlit/elements/widgets/text_widgets.py	130	6	95%
streamlit/elements/widgets/time_widgets.py	390	19	95%
streamlit/elements/write.py	166	32	81%
streamlit/emojis.py	4	0	100%
streamlit/env_util.py	21	3	86%
streamlit/error_util.py	33	2	94%
streamlit/errors.py	194	25	87%
streamlit/external/__init__.py	0	0	100%
streamlit/external/langchain/__init__.py	2	0	100%
streamlit/external/langchain/streamlit_callback_handler.py	141	82	42%
streamlit/file_util.py	84	8	90%
streamlit/git_util.py	100	5	95%
streamlit/logger.py	54	0	100%
streamlit/material_icon_names.py	1	0	100%
streamlit/navigation/__init__.py	0	0	100%
streamlit/navigation/page.py	78	2	97%
streamlit/net_util.py	55	3	95%
streamlit/platform.py	10	1	90%
streamlit/runtime/__init__.py	8	0	100%
streamlit/runtime/app_session.py	460	91	80%
streamlit/runtime/caching/__init__.py	19	0	100%
streamlit/runtime/caching/cache_data_api.py	171	3	98%
streamlit/runtime/caching/cache_errors.py	45	4	91%
streamlit/runtime/caching/cache_resource_api.py	132	1	99%
streamlit/runtime/caching/cache_type.py	11	1	91%
streamlit/runtime/caching/cache_utils.py	165	9	95%
streamlit/runtime/caching/cached_message_replay.py	108	1	99%
streamlit/runtime/caching/hashing.py	311	25	92%
streamlit/runtime/caching/legacy_cache_api.py	14	0	100%
streamlit/runtime/caching/storage/__init__.py	2	0	100%
streamlit/runtime/caching/storage/cache_storage_protocol.py	31	2	94%
streamlit/runtime/caching/storage/dummy_cache_storage.py	21	0	100%
streamlit/runtime/caching/storage/in_memory_cache_storage_wrapper.py	67	1	99%
streamlit/runtime/caching/storage/local_disk_cache_storage.py	86	4	95%
streamlit/runtime/connection_factory.py	85	9	89%
streamlit/runtime/context.py	140	0	100%
streamlit/runtime/context_util.py	18	0	100%
streamlit/runtime/credentials.py	139	4	97%
streamlit/runtime/download_data_util.py	27	0	100%
streamlit/runtime/forward_msg_cache.py	23	2	91%
streamlit/runtime/forward_msg_queue.py	63	4	94%
streamlit/runtime/fragment.py	112	2	98%
streamlit/runtime/media_file_manager.py	110	7	94%
streamlit/runtime/media_file_storage.py	15	0	100%
streamlit/runtime/memory_media_file_storage.py	73	0	100%
streamlit/runtime/memory_session_storage.py	15	0	100%
streamlit/runtime/memory_uploaded_file_manager.py	46	1	98%
streamlit/runtime/metrics_util.py	193	12	94%
streamlit/runtime/pages_manager.py	59	2	97%
streamlit/runtime/runtime.py	251	18	93%
streamlit/runtime/runtime_util.py	30	1	97%
streamlit/runtime/script_data.py	16	0	100%
streamlit/runtime/scriptrunner/__init__.py	5	0	100%
streamlit/runtime/scriptrunner/exec_code.py	49	5	90%
streamlit/runtime/scriptrunner/magic.py	83	1	99%
streamlit/runtime/scriptrunner/magic_funcs.py	10	1	90%
streamlit/runtime/scriptrunner/script_cache.py	27	0	100%
streamlit/runtime/scriptrunner/script_runner.py	230	27	88%
streamlit/runtime/scriptrunner_utils/__init__.py	0	0	100%
streamlit/runtime/scriptrunner_utils/exceptions.py	11	1	91%
streamlit/runtime/scriptrunner_utils/script_requests.py	106	5	95%
streamlit/runtime/scriptrunner_utils/script_run_context.py	134	2	99%
streamlit/runtime/secrets.py	242	25	90%
streamlit/runtime/session_manager.py	60	1	98%
streamlit/runtime/state/__init__.py	7	0	100%
streamlit/runtime/state/common.py	52	2	96%
streamlit/runtime/state/presentation.py	19	4	79%
streamlit/runtime/state/query_params.py	134	5	96%
streamlit/runtime/state/query_params_proxy.py	71	0	100%
streamlit/runtime/state/safe_session_state.py	77	9	88%
streamlit/runtime/state/session_state.py	440	33	92%
streamlit/runtime/state/session_state_proxy.py	62	8	87%
streamlit/runtime/state/widgets.py	15	1	93%
streamlit/runtime/stats.py	138	21	85%
streamlit/runtime/theme_util.py	46	1	98%
streamlit/runtime/uploaded_file_manager.py	39	3	92%
streamlit/runtime/websocket_session_manager.py	97	0	100%
streamlit/source_util.py	36	1	97%
streamlit/string_util.py	93	9	90%
streamlit/temporary_directory.py	18	1	94%
streamlit/testing/__init__.py	0	0	100%
streamlit/testing/v1/__init__.py	2	0	100%
streamlit/testing/v1/app_test.py	242	6	98%
streamlit/testing/v1/element_tree.py	1371	87	94%
streamlit/testing/v1/local_script_runner.py	71	2	97%
streamlit/testing/v1/util.py	17	0	100%
streamlit/time_util.py	28	1	96%
streamlit/type_util.py	148	16	89%
streamlit/url_util.py	39	5	87%
streamlit/user_info.py	87	8	91%
streamlit/util.py	38	1	97%
streamlit/version.py	3	0	100%
streamlit/watcher/__init__.py	3	0	100%
streamlit/watcher/event_based_path_watcher.py	181	24	87%
streamlit/watcher/folder_black_list.py	14	1	93%
streamlit/watcher/local_sources_watcher.py	127	9	93%
streamlit/watcher/path_watcher.py	42	3	93%
streamlit/watcher/polling_path_watcher.py	55	2	96%
streamlit/watcher/util.py	49	1	98%
streamlit/web/__init__.py	0	0	100%
streamlit/web/bootstrap.py	153	20	87%
streamlit/web/cache_storage_manager_config.py	5	0	100%
streamlit/web/cli.py	186	17	91%
streamlit/web/server/__init__.py	5	0	100%
streamlit/web/server/app_static_file_handler.py	29	3	90%
streamlit/web/server/authlib_tornado_integration.py	42	5	88%
streamlit/web/server/bidi_component_request_handler.py	65	8	88%
streamlit/web/server/browser_websocket_handler.py	116	31	73%
streamlit/web/server/component_file_utils.py	24	0	100%
streamlit/web/server/component_request_handler.py	55	4	93%
streamlit/web/server/media_file_handler.py	65	9	86%
streamlit/web/server/oauth_authlib_routes.py	118	18	85%
streamlit/web/server/oidc_mixin.py	46	0	100%
streamlit/web/server/routes.py	90	7	92%
streamlit/web/server/server.py	188	11	94%
streamlit/web/server/server_util.py	67	5	93%
streamlit/web/server/stats_request_handler.py	59	5	92%
streamlit/web/server/upload_file_request_handler.py	59	14	76%
streamlit/web/server/websocket_headers.py	19	1	95%
TOTAL	20996	1523	93%

📊 View detailed coverage comparison

Copilot

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated no new comments.

lukasmasuch · 2025-12-18T09:27:10Z

@cursor review

frontend/lib/src/components/shared/TooltipIcon/TooltipIcon.tsx

lukasmasuch · 2025-12-18T09:41:01Z

frontend/lib/src/components/shared/TooltipIcon/styled-components.ts

+    outline: `${theme.sizes.borderWidth} solid ${theme.colors.primary}`,
+    outlineOffset: theme.spacing.threeXS,
+    borderRadius: theme.radii.default,


question: Its probably intended that this is using outline instead of boxShadow as we use with some other aspects? Does it make sense to unify this at some point. My personal preference would be the outline style, the box shadow feels a bit heavy.

Ah, actually I want do intend to keep this consistent for now. Since everything else is boxShadow, I'm going to switch this over.

But you're right that we should unify this across the app and set up clear rules _ guidelines for this. I think we should run it by design to see what they think long-term.

Some food for thought: Tailwind uses box-shadow but react-aria uses outline.

lukasmasuch

LGTM 👍

sfc-gh-bnisco · 2025-12-22T17:24:26Z

Merge activity

Dec 22, 5:24 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Dec 22, 5:26 PM UTC: Graphite rebased this pull request as part of a merge.
Dec 22, 5:40 PM UTC: @sfc-gh-bnisco merged this pull request with Graphite.

This was referenced Dec 16, 2025

[refactor] Centralize focus ring styling #13340

Merged

[fix] Ensure anchor links in Markdown headers are accessible from keyboard #13378

Merged

sfc-gh-bnisco added change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR labels Dec 16, 2025 — with Graphite App

sfc-gh-bnisco added change:bugfix PR contains bug fix implementation and removed change:feature PR contains new feature or enhancement implementation labels Dec 16, 2025

sfc-gh-bnisco requested a review from Copilot December 16, 2025 04:41

graphite-app bot reviewed Dec 16, 2025

View reviewed changes

frontend/lib/src/components/shared/TooltipIcon/TooltipIcon.test.tsx Outdated Show resolved Hide resolved

Copilot started reviewing on behalf of sfc-gh-bnisco December 16, 2025 04:42 View session

Copilot AI reviewed Dec 16, 2025

View reviewed changes

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split branch from 8058013 to 8eeeed6 Compare December 16, 2025 05:06

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split_split branch from 19fc960 to 9d2389d Compare December 16, 2025 05:06

sfc-gh-bnisco requested a review from Copilot December 16, 2025 16:40

Copilot AI reviewed Dec 16, 2025

View reviewed changes

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split_split branch from 9d2389d to bd91eae Compare December 16, 2025 16:49

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split branch from 8eeeed6 to 92962c4 Compare December 16, 2025 16:49

sfc-gh-bnisco requested a review from Copilot December 16, 2025 16:55

Copilot AI reviewed Dec 16, 2025

View reviewed changes

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split branch from 92962c4 to 8f4981c Compare December 16, 2025 23:14

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split_split branch 2 times, most recently from fe94434 to 9678331 Compare December 16, 2025 23:21

sfc-gh-bnisco requested a review from Copilot December 16, 2025 23:21

Copilot started reviewing on behalf of sfc-gh-bnisco December 16, 2025 23:21 View session

Copilot AI reviewed Dec 16, 2025

View reviewed changes

frontend/lib/src/components/shared/TooltipIcon/TooltipIcon.test.tsx Outdated Show resolved Hide resolved

Copilot started reviewing on behalf of sfc-gh-bnisco December 16, 2025 23:57 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split_split branch from 890c54b to 2b0685b Compare December 17, 2025 00:07

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split branch from 970be49 to b9ebcd3 Compare December 17, 2025 00:07

sfc-gh-bnisco marked this pull request as ready for review December 17, 2025 00:56

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split branch from b9ebcd3 to a97d86d Compare December 17, 2025 16:48

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split_split branch from 2b0685b to a43eaa6 Compare December 17, 2025 16:48

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split branch from a97d86d to 13c6d1e Compare December 17, 2025 16:52

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split_split branch from a43eaa6 to 4a5eaaa Compare December 17, 2025 16:52

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split branch 2 times, most recently from 2b8e1d2 to 8a2c991 Compare December 17, 2025 17:21

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split_split branch from 4a5eaaa to 1ca104b Compare December 17, 2025 17:21

cursor bot reviewed Dec 18, 2025

View reviewed changes

frontend/lib/src/components/shared/TooltipIcon/TooltipIcon.tsx Show resolved Hide resolved

lukasmasuch reviewed Dec 18, 2025

View reviewed changes

lukasmasuch approved these changes Dec 18, 2025

View reviewed changes

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split branch from 8a2c991 to c1661f5 Compare December 18, 2025 17:25

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split_split branch 2 times, most recently from a721158 to df76e8b Compare December 18, 2025 17:28

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split branch from c1661f5 to 2e5419f Compare December 18, 2025 17:28

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split_split branch from df76e8b to 4d7a96e Compare December 18, 2025 17:42

This was referenced Dec 18, 2025

[feat] Update AGENTS rules for better a11y practices #13411

Merged

[feat] Update eslint rules for better a11y support #13412

Merged

sfc-gh-bnisco changed the base branch from 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split to graphite-base/13379 December 22, 2025 17:24

sfc-gh-bnisco changed the base branch from graphite-base/13379 to develop December 22, 2025 17:24

[fix] Ensure help Tooltips are accessible

fb7e0b0

sfc-gh-bnisco force-pushed the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split_split branch from 4d7a96e to fb7e0b0 Compare December 22, 2025 17:25

sfc-gh-bnisco merged commit 1e88813 into develop Dec 22, 2025
43 checks passed

sfc-gh-bnisco deleted the 12-12-_feat_improve_accessibility_of_tooltips_and_markdown_split_split branch December 22, 2025 17:40

[fix] Ensure help Tooltips are accessible #13379

[fix] Ensure help Tooltips are accessible #13379

Uh oh!

Conversation

sfc-gh-bnisco commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Screenshot or video (only for visual changes)

GitHub Issue Link (if applicable)

Testing Plan

Uh oh!

snyk-io bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

github-actions bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ PR preview is ready!

Uh oh!

sfc-gh-bnisco commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

github-actions bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📈 Frontend coverage change detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📈 Python coverage change detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

lukasmasuch commented Dec 18, 2025

Uh oh!

Uh oh!

lukasmasuch Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-bnisco Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

lukasmasuch left a comment

Choose a reason for hiding this comment

Uh oh!

sfc-gh-bnisco commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

sfc-gh-bnisco commented Dec 16, 2025 •

edited

Loading

snyk-io bot commented Dec 16, 2025 •

edited

Loading

github-actions bot commented Dec 16, 2025 •

edited

Loading

sfc-gh-bnisco commented Dec 16, 2025 •

edited

Loading

github-actions bot commented Dec 16, 2025 •

edited

Loading

github-actions bot commented Dec 16, 2025 •

edited

Loading

sfc-gh-bnisco commented Dec 22, 2025 •

edited

Loading